You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jayeshchoudhary (via GitHub)" <gi...@apache.org> on 2024/06/02 18:00:30 UTC
[PR] update node version in the docs [pinot]
jayeshchoudhary opened a new pull request, #13294:
URL: https://github.com/apache/pinot/pull/13294
we recently updated node version in https://github.com/apache/pinot/pull/12924. This PR is to reflect the same in redme instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1625141084
##########
pinot-controller/src/main/resources/Readme.md:
##########
@@ -29,7 +29,7 @@ This package contains code for Pinot Controller UI.
```shell
cd pinot-controller/src/main/resources
```
-3. Install Required Packages. Make sure you are using node v14 or more specifially v14.18.1
+3. Install Required Packages. Make sure you are using node v14 or more specifically v16.15.0
Review Comment:
Do we need to also update the major version?
```suggestion
3. Install Required Packages. Make sure you are using node v16 or more specifically v16.15.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1623637074
##########
pinot-controller/src/main/resources/Readme.md:
##########
@@ -29,7 +29,7 @@ This package contains code for Pinot Controller UI.
```shell
cd pinot-controller/src/main/resources
```
-3. Install Required Packages. Make sure you are using node v14 or more specifially v14.18.1
+3. Install Required Packages. Make sure you are using node v14 or more specifically v16.15.0
Review Comment:
this is the change right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1625780167
##########
README.md:
##########
@@ -102,6 +102,8 @@ $ cd build/
$ bin/quick-start-batch.sh
```
+For UI development setup refer this [doc](https://github.com/jayeshchoudhary/pinot/blob/master/pinot-controller/src/main/resources/Readme.md).
Review Comment:
Right I missed this.
##########
pinot-controller/src/main/resources/Readme.md:
##########
@@ -29,7 +29,7 @@ This package contains code for Pinot Controller UI.
```shell
cd pinot-controller/src/main/resources
```
-3. Install Required Packages. Make sure you are using node v14 or more specifially v14.18.1
+3. Install Required Packages. Make sure you are using node v14 or more specifically v16.15.0
Review Comment:
Right I missed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1625780167
##########
README.md:
##########
@@ -102,6 +102,8 @@ $ cd build/
$ bin/quick-start-batch.sh
```
+For UI development setup refer this [doc](https://github.com/jayeshchoudhary/pinot/blob/master/pinot-controller/src/main/resources/Readme.md).
Review Comment:
Right I missed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1623637103
##########
README.md:
##########
@@ -102,6 +102,8 @@ $ cd build/
$ bin/quick-start-batch.sh
```
+For UI development setup refer this [doc](https://github.com/jayeshchoudhary/pinot/blob/master/pinot-controller/src/main/resources/Readme.md).
Review Comment:
which apache repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #13294:
URL: https://github.com/apache/pinot/pull/13294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "jayeshchoudhary (via GitHub)" <gi...@apache.org>.
jayeshchoudhary commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1623637103
##########
README.md:
##########
@@ -102,6 +102,8 @@ $ cd build/
$ bin/quick-start-batch.sh
```
+For UI development setup refer this [doc](https://github.com/jayeshchoudhary/pinot/blob/master/pinot-controller/src/main/resources/Readme.md).
Review Comment:
which apache repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] update node version in the docs [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #13294:
URL: https://github.com/apache/pinot/pull/13294#discussion_r1623631745
##########
pinot-controller/src/main/resources/Readme.md:
##########
@@ -29,7 +29,7 @@ This package contains code for Pinot Controller UI.
```shell
cd pinot-controller/src/main/resources
```
-3. Install Required Packages. Make sure you are using node v14 or more specifially v14.18.1
+3. Install Required Packages. Make sure you are using node v14 or more specifically v16.15.0
Review Comment:
Should we also modify `v14` to `v16`?
##########
README.md:
##########
@@ -102,6 +102,8 @@ $ cd build/
$ bin/quick-start-batch.sh
```
+For UI development setup refer this [doc](https://github.com/jayeshchoudhary/pinot/blob/master/pinot-controller/src/main/resources/Readme.md).
Review Comment:
Can you modify this to the Apache repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org