You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 03:58:03 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #43088: [SPARK-45303][CORE] Remove JDK 8/11 workaround in KryoSerializerBenchmark
HyukjinKwon opened a new pull request, #43088:
URL: https://github.com/apache/spark/pull/43088
### What changes were proposed in this pull request?
This PR removes the legacy workaround for JDK 8/11 in SPARK-29282.
They were already removed in SPARK-37293. This is the leftover.
### Why are the changes needed?
For consistency.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Fixed unittests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43088: [SPARK-45303][CORE] Remove JDK 8/11 workaround in KryoSerializerBenchmark
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43088:
URL: https://github.com/apache/spark/pull/43088#issuecomment-1732878129
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43088: [SPARK-45303][CORE] Remove JDK 8/11 workaround in KryoSerializerBenchmark
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43088:
URL: https://github.com/apache/spark/pull/43088#discussion_r1335350938
##########
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala:
##########
@@ -23,7 +23,7 @@ import org.apache.spark.internal.config.Tests.IS_TESTING
/**
* A base class for generate benchmark results to a file.
- * For JDK9+, JDK major version number is added to the file names to distinguish the results.
+ * For JDK 21+, JDK major version number is added to the file names to distinguish the results.
Review Comment:
While I am here, I piggyback a typo fix but I can separate them if anyone prefers that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #43088: [SPARK-45303][CORE] Remove JDK 8/11 workaround in KryoSerializerBenchmark
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43088: [SPARK-45303][CORE] Remove JDK 8/11 workaround in KryoSerializerBenchmark
URL: https://github.com/apache/spark/pull/43088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org