You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hertzbeat.apache.org by "LinuxSuRen (via GitHub)" <gi...@apache.org> on 2024/09/05 06:14:17 UTC

[PR] chore: make the controller response be easy [hertzbeat]

LinuxSuRen opened a new pull request, #2679:
URL: https://github.com/apache/hertzbeat/pull/2679

   ## What's changed?
   
   <!-- Describe Your PR Here -->
   Below is the test result
   
   ![image](https://github.com/user-attachments/assets/59766ff7-ff06-456a-a7f7-04bbac42d0ce)
   
   
   ## Checklist
   
   - [x]  I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [x]  I have written the necessary doc or comment.
   - [x]  I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org

Re: [PR] chore: make the controller response be easy [hertzbeat]

Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx commented on PR #2679:
URL: https://github.com/apache/hertzbeat/pull/2679#issuecomment-2330911767

   ptal @tomsun28 @zqr10159 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org

Re: [PR] chore: make the controller response be easy [hertzbeat]

Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 merged PR #2679:
URL: https://github.com/apache/hertzbeat/pull/2679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org

Re: [PR] chore: make the controller response be easy [hertzbeat]

Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on PR #2679:
URL: https://github.com/apache/hertzbeat/pull/2679#issuecomment-2333165229

   +1 the response stru may not always same


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org

Re: [PR] chore: make the controller response be easy [hertzbeat]

Posted by "Calvin979 (via GitHub)" <gi...@apache.org>.
Calvin979 commented on PR #2679:
URL: https://github.com/apache/hertzbeat/pull/2679#issuecomment-2332022207

   How about use `ResponseBodyAdvice` to handle response entity globally? @tomsun28 @LinuxSuRen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org

Re: [PR] chore: make the controller response be easy [hertzbeat]

Posted by "LinuxSuRen (via GitHub)" <gi...@apache.org>.
LinuxSuRen commented on PR #2679:
URL: https://github.com/apache/hertzbeat/pull/2679#issuecomment-2332815215

   I'm not sure if all controllers could have the same or similar way to handle it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org