You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2009/09/09 01:30:42 UTC

Re: Please do a partial revert: Re: svn commit: r802567 [1/5] - in /ofbiz/trunk: applications/order/src/org/ofbiz/order/shoppingcart/ applications/product/src/org/ofbiz/shipment/packing/ applications/product/src/org/ofbiz/shipment/verify/ applications/prod

+1, I agree Adam has well shown the way

Jacques

From: "Tim Ruppert" <ti...@hotwaxmedia.com>
> +1 - thanks Adam - I agree whole heartedly on the incremental approach.
> 
> Cheers,
> Ruppert
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
> 
> o:801.649.6594
> f:801.649.6595
> 
> On Sep 8, 2009, at 4:56 PM, Adam Heath wrote:
> 
>> Adam Heath wrote:
>>> I have external code(webslinger) that needs to support multiple
>>> versions of ofbiz(one all the way back to 512946).  This change makes
>>> that impossible.  I have to have multiple versions of ofbiz
>>> installed(pre/post this change), and compile the class once for each
>>> ofbiz version.
>>
>> Well, based on this change, and what will eventually happen with
>> ExecutionContext, I've changed my build to support this.  Kinda slick
>> actually.
>>
>> I copied the old GenericDelegator.java, new GenericDelegator.java, and
>> DelegatorInterface.java, into my local build system.  Modified the old
>> delegator, removing all comments, all method bodies, and made them all
>> throw UnsupportedOperationException.  Compiled these classes locally.
>> Do some classpath tweaks during the build phase, and have 2 versions
>> of ofbiz-webslinger.jar.  I then use debian versioned dependencies to
>> install the correct jar.
>>
>> So, I don't need this backed out right now, altho I do think it is
>> still the correct thing to do.  I also think an incremental approach
>> to ExecutionContext is also the preferred way.
> 
>