You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/29 13:54:59 UTC

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #453: [FLINK-30216] Improve code quality by standardising tab/spaces in pom…

darenwkt commented on code in PR #453:
URL: https://github.com/apache/flink-kubernetes-operator/pull/453#discussion_r1034783258


##########
pom.xml:
##########
@@ -349,6 +349,36 @@ under the License.
                     </transformers>
                 </configuration>
             </plugin>
+
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>xml-maven-plugin</artifactId>
+                <version>1.0.2</version>
+                <configuration>
+                    <indentSize>4</indentSize>
+                    <useDefaultFormatFileSet>false</useDefaultFormatFileSet>
+                    <formatFileSets>
+                        <formatFileSet>
+                            <directory>.</directory>
+                            <excludes>
+                                <exclude>**</exclude>

Review Comment:
   Hi @mbalassi, thank you for the feedback, I agree with your commend that include alone is sufficient. Have updated the PR, thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org