You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "iqinning (via GitHub)" <gi...@apache.org> on 2023/05/06 14:44:44 UTC
[GitHub] [dubbo] iqinning opened a new pull request, #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
iqinning opened a new pull request, #12246:
URL: https://github.com/apache/dubbo/pull/12246
…recursively search the base class (#12245)
## What is the purpose of the change
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #12246:
URL: https://github.com/apache/dubbo/pull/12246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12246:
URL: https://github.com/apache/dubbo/pull/12246#issuecomment-1537168825
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/12246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12246](https://app.codecov.io/gh/apache/dubbo/pull/12246?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1a5c2f) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/c5f8ce64787cbb17628ac5176947d46a457ee0ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f8ce6) will **increase** coverage by `0.74%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.2 #12246 +/- ##
============================================
+ Coverage 68.82% 69.56% +0.74%
+ Complexity 115 2 -113
============================================
Files 3559 1603 -1956
Lines 163607 65813 -97794
Branches 26766 9602 -17164
============================================
- Hits 112602 45786 -66816
+ Misses 41203 15629 -25574
+ Partials 9802 4398 -5404
```
[see 1987 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/12246/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] suncairong163 commented on pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "suncairong163 (via GitHub)" <gi...@apache.org>.
suncairong163 commented on PR #12246:
URL: https://github.com/apache/dubbo/pull/12246#issuecomment-1537439776
ExceptionHandler的功能是来自于spring的controllerAdvice和restEasy的ExceptionMapper,这两者都是对某一个具体类型的Exception做处理的，我看这个更改逻辑是为了向上查找super的ExceptionHandler,就不是某种具体类型的处理了，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12246:
URL: https://github.com/apache/dubbo/pull/12246#issuecomment-1537167630
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12246)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12246&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12246&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12246&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12246&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12246&metric=new_coverage&view=list) [94.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12246&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12246&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12246&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] iqinning commented on pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "iqinning (via GitHub)" <gi...@apache.org>.
iqinning commented on PR #12246:
URL: https://github.com/apache/dubbo/pull/12246#issuecomment-1537554651
> ExceptionHandler的功能是来自于spring的controllerAdvice和restEasy的ExceptionMapper,这两者都是对某一个具体类型的Exception做处理的，我看这个更改逻辑是为了向上查找super的ExceptionHandler,就不是某种具体类型的处理了，
据我了解，不管是 spring mvc 的异常处理器查找机制，还是rest easy 都是往基类查找的以下是 rest-easy 处理代码
```
/**
* Execute an ExceptionMapper if one exists for the given exception. Recurse to base class if not found
*
* @param exception
* @return true if an ExceptionMapper was found and executed
*/
@SuppressWarnings(value = "unchecked")
public Response executeExceptionMapper(Throwable exception)
{
ExceptionMapper mapper = null;
Class causeClass = exception.getClass();
while (mapper == null) {
if (causeClass == null) break;
mapper = providerFactory.getExceptionMappers().get(causeClass);
if (mapper == null) causeClass = causeClass.getSuperclass();
}
if (mapper != null) {
mapperExecuted = true;
Response jaxrsResponse = mapper.toResponse(exception);
if (jaxrsResponse == null) {
jaxrsResponse = Response.status(204).build();
}
return jaxrsResponse;
}
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] suncairong163 commented on pull request #12246: fix When the exception handling class cannot be obtained, it should recursively search the base class(#12245)
Posted by "suncairong163 (via GitHub)" <gi...@apache.org>.
suncairong163 commented on PR #12246:
URL: https://github.com/apache/dubbo/pull/12246#issuecomment-1537621086
ok，那就没问题了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org