You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Alex Parvulescu (Created) (JIRA)" <ji...@apache.org> on 2011/10/17 17:14:10 UTC
[jira] [Created] (JCR-3117) Stats for the PersistenceManager
Stats for the PersistenceManager
--------------------------------
Key: JCR-3117
URL: https://issues.apache.org/jira/browse/JCR-3117
Project: Jackrabbit Content Repository
Issue Type: Sub-task
Reporter: Alex Parvulescu
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3117:
---------------------------------
Description:
Statistics for the PersistenceManager impl that cover:
- bundle cache access count,
- bundle cache miss count,
- bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
- bundle writes per second
What it doesn't cover is :
- number of bundles
- size of workspace
as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
Priority: Minor (was: Major)
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Priority: Minor
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131485#comment-13131485 ]
Alex Parvulescu commented on JCR-3117:
--------------------------------------
> This replaces 222 lines of code with just 63
the purpose of saving all these lines is lost on me.
+1 on the patch
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch, JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3117) Stats for the PersistenceManager
Posted by "Jukka Zitting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3117:
-------------------------------
Attachment: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch
The proposed patch switches the PM stats to use the TimeSeries mechanism. This replaces 222 lines of code with just 63, while increasing the amount of collected information.
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch, JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131476#comment-13131476 ]
Alex Parvulescu commented on JCR-3117:
--------------------------------------
Hi Jukka,
can you be a bit more specific? I'm not sure what you want to replace with the TimeSeries:
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
Out of all the stats provided here, I'd say the 'bundle writes per second' fall into the TimeSeries scope. And there, I don't mind replacing the mechanism.
As for the rest:
- the 2 counts are just incremental operations on AtomicLong, I don't really see the added value in using TS;
- the 'cache miss avg duration' : AFAIK the TS impl does not do averages currently, if it will, I'm open for using it.
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3117) Stats for the PersistenceManager
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-3117.
--------------------------------
Resolution: Fixed
I added also average time series in revision 1188678.
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch, JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3117:
---------------------------------
Attachment: JCR-3117.patch
attached proposed patch
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Priority: Minor
> Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu reopened JCR-3117:
----------------------------------
Assignee: (was: Alex Parvulescu)
reopening to reconsider new patches
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch, JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3117) Stats for the PersistenceManager
Posted by "Alex Parvulescu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu resolved JCR-3117.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.3.2
Assignee: Alex Parvulescu
Fixed in revision 1186195.
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3117) Stats for the PersistenceManager
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131462#comment-13131462 ]
Jukka Zitting commented on JCR-3117:
------------------------------------
Wouldn't it be easier to just use the AtomicLong counters from the TimeSeries mechanism? That way we wouldn't have to add new interfaces and implementations for each piece of statistics we want to collect?
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3117) Stats for the PersistenceManager
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131482#comment-13131482 ]
Jukka Zitting commented on JCR-3117:
------------------------------------
> the 2 counts are just incremental operations on AtomicLong, I don't really see the added value in using TS;
There's two main benefits: 1) we get a full time series of the collected values, and 2) we don't need the extra interface or custom code for accessing this piece of information.
> the 'cache miss avg duration' : AFAIK the TS impl does not do averages currently, if it will, I'm open for using it.
The average duration is easily calculated by dividing total duration by count per second. It's not currently supported by the TS implementation, but will be easy enough to add.
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: 0001-JCR-3117-Stats-for-the-PersistenceManager.patch, JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3117) Stats for the PersistenceManager
Posted by "Stefan Guggisberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130443#comment-13130443 ]
Stefan Guggisberg commented on JCR-3117:
----------------------------------------
patch looks good, thanks!
> Stats for the PersistenceManager
> --------------------------------
>
> Key: JCR-3117
> URL: https://issues.apache.org/jira/browse/JCR-3117
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Alex Parvulescu
> Priority: Minor
> Attachments: JCR-3117.patch
>
>
> Statistics for the PersistenceManager impl that cover:
> - bundle cache access count,
> - bundle cache miss count,
> - bundle cache miss avg duration (this avg includes the penalty of having to load from the underlying storage / can be interpreted as avg read latency as there is no cache involved)
> - bundle writes per second
> What it doesn't cover is :
> - number of bundles
> - size of workspace
> as these are values that are expensive to compute on demand, and caching them would imply being able to store the values (which is not possible currently).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira