You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by pbchou <gi...@git.apache.org> on 2016/06/01 22:52:12 UTC
[GitHub] trafficserver pull request #690: TS-4498: Enhanced the error message appeari...
GitHub user pbchou opened a pull request:
https://github.com/apache/trafficserver/pull/690
TS-4498: Enhanced the error message appearing in diags.log when a rem\u2026
\u2026ap plugin
fails during initialization, i.e., print out tmpbuf which may contain
error information set by the plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pbchou/trafficserver TS-4498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 74472670e53c90ececfc1b55f813771081dfefc5
Author: Peter Chou <pb...@labs.att.com>
Date: 2016-06-01T22:44:08Z
TS-4498: Enhanced the error message appearing in diags.log when a remap plugin
fails during initialization, i.e., print out tmpbuf which may contain
error information set by the plugin.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #690: TS-4498: Enhanced the error message appearing in d...
Posted by pbchou <gi...@git.apache.org>.
Github user pbchou commented on the issue:
https://github.com/apache/trafficserver/pull/690
Made recommended fixes detailed in the comment above from @jpeach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #690: TS-4498: Enhanced the error message appeari...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #690: TS-4498: Enhanced the error message appearing in d...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/690
Thanks @pbchou. I think we can make this a more complete fix. If you look at the way ``remap_load_plugin`` works, it it supposed to return non-zero on error and write the error message to ``errbuf``. Rather than emitting a ``Warning`` in ``remap_load_plugin``, we should format the error into the output error buffer. Then the real error message will be available in ``remap_parse_config_bti``, and we will emit the message correctly. Additionally, I think the ``Warning`` at ``MAP_ERROR`` and ``SignalError()`` should be ``Error``.
Later we can look at improving this with [TS-4501](https://issues.apache.org/jira/browse/TS-4501).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---