You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/05/17 20:24:38 UTC

[jira] [Created] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Jimmy Xiang created HBASE-6033:
----------------------------------

             Summary: Adding some fuction to check if a table/region is in compaction
                 Key: HBASE-6033
                 URL: https://issues.apache.org/jira/browse/HBASE-6033
             Project: HBase
          Issue Type: New Feature
            Reporter: Jimmy Xiang


This feature will be helpful to find out if a major compaction is going on.
We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Attachment: hbase_6033_v5.patch
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279588#comment-13279588 ] 

Jimmy Xiang commented on HBASE-6033:
------------------------------------

A snapshot of the table UI is attached.  The review board doesn't recognize it as a valid image.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282111#comment-13282111 ] 

Zhihong Yu commented on HBASE-6033:
-----------------------------------

Patch v5 would pass TestCompactionState.
But the loop may end up finding compaction state as being CompactionState.NONE

Can we verify that major/minor compaction indeed took place in the above scenario ?
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-6033:
------------------------------

    Attachment: 6033-v7.txt

Re-attach patch v7 which corrects formatting.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-6033:
------------------------------

    Attachment:     (was: 6033-v7.txt)
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Attachment: hbase-6033_v2.patch
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280719#comment-13280719 ] 

Hadoop QA commented on HBASE-6033:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528550/hbase-6033_v2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestCompactionState
                  org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1955//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1955//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1955//console

This message is automatically generated.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Attachment: table_ui.png
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282136#comment-13282136 ] 

Hadoop QA commented on HBASE-6033:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528831/hbase_6033_v5.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1978//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1978//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1978//console

This message is automatically generated.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-6033:
------------------------------

    Attachment: 6033-v7.txt

Patch v7 places the second loop of compaction() in an else block, waiting for compaction to complete.
Also added assertion w.r.t. the number of store files after compaction.
Also added '@org.junit.Rule'

TestCompactionState passes on MacBook.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Attachment: hbase_6033_v6.patch
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283259#comment-13283259 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-TRUNK #2921 (See [https://builds.apache.org/job/HBase-TRUNK/2921/])
    HBASE-6033 Addendum changes TestCompactionState to large test (Revision 1342196)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465098#comment-13465098 ] 

Harsh J commented on HBASE-6033:
--------------------------------

This was backported to 0.90, 0.92 and 0.94 releases. Can someone set the appropriate fix sub-versions for each?
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-6033:
------------------------------

    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed

Integrated to trunk.

Thanks for the patch, Jimmy.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang reassigned HBASE-6033:
----------------------------------

    Assignee: Jimmy Xiang
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283832#comment-13283832 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #16 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/16/])
    HBASE-6033 Addendum changes TestCompactionState to large test (Revision 1342196)
HBASE-6033 Adding some fuction to check if a table/region is in compaction (Jimmy) (Revision 1342149)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
* /hbase/trunk/src/test/resources/hbase-site.xml

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278068#comment-13278068 ] 

Zhihong Yu commented on HBASE-6033:
-----------------------------------

+1 on this feature.

It would be nice to see this information on region server / table web UI.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Attachment: hbase-6033_v3.patch

Now unit test should be green.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282135#comment-13282135 ] 

Jimmy Xiang commented on HBASE-6033:
------------------------------------

That's a good idea.  Let me add some checking to make sure the file count is decreased.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287185#comment-13287185 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-0.94-security #33 (See [https://builds.apache.org/job/HBase-0.94-security/33/])
    HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286043#comment-13286043 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-0.94 #235 (See [https://builds.apache.org/job/HBase-0.94/235/])
    HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Status: Open  (was: Patch Available)
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287247#comment-13287247 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-0.92-security #109 (See [https://builds.apache.org/job/HBase-0.92-security/109/])
    HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446)

     Result = SUCCESS
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280729#comment-13280729 ] 

Zhihong Yu commented on HBASE-6033:
-----------------------------------

@Jimmy:
Can you check why TestCompactionState failed ?
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282235#comment-13282235 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-TRUNK #2920 (See [https://builds.apache.org/job/HBase-TRUNK/2920/])
    HBASE-6033 Adding some fuction to check if a table/region is in compaction (Jimmy) (Revision 1342149)

     Result = SUCCESS
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/trunk/src/main/protobuf/Admin.proto
* /hbase/trunk/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
* /hbase/trunk/src/test/resources/hbase-site.xml

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282210#comment-13282210 ] 

Hadoop QA commented on HBASE-6033:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528847/6033-v7.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1980//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1980//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1980//console

This message is automatically generated.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281963#comment-13281963 ] 

Hadoop QA commented on HBASE-6033:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528784/hbase-6033_v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.replication.TestMasterReplication

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1970//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1970//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1970//console

This message is automatically generated.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465107#comment-13465107 ] 

Jimmy Xiang commented on HBASE-6033:
------------------------------------

The backport was done with HBASE-6124.  I just linked it here.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465472#comment-13465472 ] 

Harsh J commented on HBASE-6033:
--------------------------------

My bad, thanks Jimmy!
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286150#comment-13286150 ] 

Hudson commented on HBASE-6033:
-------------------------------

Integrated in HBase-0.92 #434 (See [https://builds.apache.org/job/HBase-0.92/434/])
    HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp

                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282162#comment-13282162 ] 

Hadoop QA commented on HBASE-6033:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528841/hbase_6033_v6.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 hadoop23.  The patch compiles against the hadoop 0.23.x profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1979//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1979//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1979//console

This message is automatically generated.
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6033:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6033-v7.txt, hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280518#comment-13280518 ] 

Jimmy Xiang commented on HBASE-6033:
------------------------------------

Here is the review request:

https://reviews.apache.org/r/5167/
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6033) Adding some fuction to check if a table/region is in compaction

Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282168#comment-13282168 ] 

Zhihong Yu commented on HBASE-6033:
-----------------------------------

{code}
+      }
+      else {
{code}
Please move else to the end of line above.
{code}
+      while (state == CompactionState.NONE && curt < endt) {
+        Thread.sleep(100);
{code}
Please use a shorter sleep interval.
{code}
+      while (state != CompactionState.NONE && curt < endt) {
{code}
Why do we have a similar loop the second time ?
{code}
+      assertTrue(countAfter < countBefore);
{code}
Can we judge countAfter quantitatively to determine whether major compaction or minor compaction happened ?
                
> Adding some fuction to check if a table/region is in compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-6033
>                 URL: https://issues.apache.org/jira/browse/HBASE-6033
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png
>
>
> This feature will be helpful to find out if a major compaction is going on.
> We can show if it is in any minor compaction too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira