[PR] Follow the AI Sessionizer's id and round rules in AI agent conversations [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng opened a new pull request, #14150:
URL: https://github.com/apache/skywalking/pull/14150

   ### Follow the AI Sessionizer's id and round rules in AI agent conversations
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [x] Update the documentation to include this new feature.
   - [x] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
   
   This follows apache/skywalking-ai-sessionizer#80, which changes how the Sessionizer writes ids and how a reader treats
   an empty round line. The OAP mirrors the document the Sessionizer defines.
   
   - **The session node.** A part of an id now writes `%` as `%25` and `/` as `%2F`. `ConversationViewBuilder` rebuilt the
     session node's id with the old rule, so for a session holding either it found no node, and reported a zero time
     range and no provider bodies. It now uses the new spelling.
   - **The sessions listed.** The document read sessions back out of session node ids, and the query service read files
     for each, which could name a session that does not exist. Both now use the one session the rounds carry, as the
     Sessionizer does: a fold takes only rounds of round 1's session.
   - **Empty lines.** `SessionFlowRound` skipped an empty line. Session Flow says such a line does not decode, so the round
     is now refused; the newline that ends the last line leaves nothing after it and stays allowed.
   
   **Tests.**
   - `escaped-session/r000001-71d916485e42.sf` is a round the Sessionizer's own writer made for session `s%foo/bar`.
     `aSessionIdThatHoldsAnEscapeIsFoundByItsNode` checks the document lists that one session and takes its time range and
     provider bodies from its node.
   - `anEmptyLineIsRefused` puts an empty line before the header, between frames and after the commit.
   - Each rule was proven by reverting it and seeing its test fail.
   
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Follow the AI Sessionizer's id and round rules in AI agent conversations [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng merged PR #14150:
URL: https://github.com/apache/skywalking/pull/14150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org