You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by John Peacock <jo...@havurah-software.org> on 2008/06/08 15:05:34 UTC
[PATCH] was Re: Minor nit with Makefile
Sorry, I had a server outage and one of my MX's was misconfigured, so I didn't
see this response:
> C. Michael Pilato wrote:
>
> Well, I wonder if the right (as in, "most conservative") thing to do would be:
>
> check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
>
> (because 'bin' is the rule that builds 'svn', 'svnadmin', 'svnlook', etc.)
>
> ?
Yeah, that seems better and it works too!
[[[
'make check' should build all binaries if not already built
* Makefile.in
add 'bin' to check: target of top level Makefile
]]]
Index: Makefile.in
===================================================================
--- Makefile.in (revision 31610)
+++ Makefile.in (working copy)
@@ -376,7 +376,7 @@
# "make check CLEANUP=true" will clean up directories for successful tests.
# "make check TESTS=subversion/tests/cmdline/basic_tests.py"
# will perform only basic tests (likewise for other tests).
-check: $(TEST_DEPS) @BDB_TEST_DEPS@
+check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
@if test "$(PYTHON)" != "none"; then \
flags="--verbose"; \
if test "$(CLEANUP)" != ""; then \
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] was Re: Minor nit with Makefile
Posted by "C. Michael Pilato" <cm...@collab.net>.
Committed in r31656.
John Peacock wrote:
> Sorry, I had a server outage and one of my MX's was misconfigured, so I
> didn't see this response:
>
>> C. Michael Pilato wrote:
>>
>> Well, I wonder if the right (as in, "most conservative") thing to do
>> would be:
>>
>> check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
>>
>> (because 'bin' is the rule that builds 'svn', 'svnadmin', 'svnlook',
>> etc.)
>>
>> ?
>
> Yeah, that seems better and it works too!
>
> [[[
>
> 'make check' should build all binaries if not already built
>
> * Makefile.in
> add 'bin' to check: target of top level Makefile
>
> ]]]
>
> Index: Makefile.in
> ===================================================================
> --- Makefile.in (revision 31610)
> +++ Makefile.in (working copy)
> @@ -376,7 +376,7 @@
> # "make check CLEANUP=true" will clean up directories for successful
> tests.
> # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
> # will perform only basic tests (likewise for other tests).
> -check: $(TEST_DEPS) @BDB_TEST_DEPS@
> +check: bin $(TEST_DEPS) @BDB_TEST_DEPS@
> @if test "$(PYTHON)" != "none";
> then \
>
> flags="--verbose"; \
> if test "$(CLEANUP)" != "";
> then \
>
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand