You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "deardeng (via GitHub)" <gi...@apache.org> on 2026/10/12 07:14:20 UTC
[PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
deardeng opened a new pull request, #68947:
URL: https://github.com/apache/doris/pull/68947
pick from https://github.com/apache/doris/pull/68066
Problem Summary: When a BE in a non-normal cloud cluster stays offline, every failed heartbeat after the lost-heartbeat threshold submits another transaction cleanup task. Each task queries get_prepare_txn_by_coordinator, which scans the instance transaction metadata even after cleanup finishes. Restrict these submissions to lost-heartbeat durations in [T, 2T), where T is
abort_txn_after_lost_heartbeat_time_second. Keep the existing behavior for NORMAL cloud clusters and non-cloud deployments. This deliberately stops further submissions after the window even if earlier cleanup attempts failed.
Limit repeated transaction cleanup task submissions for offline BEs in non-normal cloud clusters to a bounded window (5 to 10 minutes after the last successful heartbeat with the default configuration).
- Test: Add HeartbeatMgrTest coverage for all four non-normal cluster states, durations before/inside/after the window, NORMAL and non-cloud behavior, replay, and missing successful heartbeats. Tests and local compilation were not run as requested. Checkstyle on both changed files and git diff --check passed.
- Behavior changed: Yes, stop submitting BE-down cleanup tasks for non-normal cloud clusters once the lost-heartbeat duration reaches twice the threshold.
- Does this need documentation: No
(cherry picked from commit 0b0ae09153153c73d22e1b2e225f3ae6061a3d2c)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6119544070
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6124382191
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6124381239
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6122993136
# FE Regression Coverage Report
Increment line coverage ` 60.00% (3/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68947_8e724ac55aae5ee75b5c5196b73d38e03a99a5af_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68947_8e724ac55aae5ee75b5c5196b73d38e03a99a5af_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6122107716
# FE UT Coverage Report
Increment line coverage ` 100.00% (5/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68947_8e724ac55aae5ee75b5c5196b73d38e03a99a5af/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68947_8e724ac55aae5ee75b5c5196b73d38e03a99a5af/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #68947:
URL: https://github.com/apache/doris/pull/68947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) Bound abort task submissions for non-normal clusters (#68066) [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #68947:
URL: https://github.com/apache/doris/pull/68947#issuecomment-6119545086
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org