You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/09/28 21:41:40 UTC
[GitHub] trafficserver pull request #1061: TS-4903: EISCONN errors when using TCP Fas...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1061
TS-4903: EISCONN errors when using TCP Fast Open.
The write VIO is reset when we reuse a VC, so we need to explicitly
track whether we have connected a TCP Fast Open socket. In the
previous patch we eschewed using the is_connected state of the
Connection, but that is explicitly what we want so we should just
use it and allow the Connection to be not connected until the Fast
Open connects it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4903
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1061
----
commit 707cdf9d587d09c3bebfdd8160d1557f0958646d
Author: James Peach <jp...@apache.org>
Date: 2016-09-28T21:38:49Z
TS-4903: EISCONN errors when using TCP Fast Open.
The write VIO is reset when we reuse a VC, so we need to explicitly
track whether we have connected a TCP Fast Open socket. In the
previous patch we eschewed using the is_connected state of the
Connection, but that is explicitly what we want so we should just
use it and allow the Connection to be not connected until the Fast
Open connects it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1061: TS-4903: EISCONN errors when using TCP Fas...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1061#discussion_r81033130
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -71,8 +71,8 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
NET_INCREMENT_DYN_STAT(net_fastopen_attempts_stat);
err = socketManager.sendto(bio->num, (void *)in, insz, MSG_FASTOPEN, dst, ats_ip_size(dst));
- if (err < 0) {
- NET_INCREMENT_DYN_STAT(net_fastopen_failures_stat);
+ if (err > 0) {
--- End diff --
It is borderline. I changed it to ``>=`` to be consistent with the other metric increment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1061: TS-4903: EISCONN errors when using TCP Fast Open.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1061
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/793/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1061: TS-4903: EISCONN errors when using TCP Fast Open.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1061
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/791/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1061: TS-4903: EISCONN errors when using TCP Fas...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1061#discussion_r81029938
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -71,8 +71,8 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
NET_INCREMENT_DYN_STAT(net_fastopen_attempts_stat);
err = socketManager.sendto(bio->num, (void *)in, insz, MSG_FASTOPEN, dst, ats_ip_size(dst));
- if (err < 0) {
- NET_INCREMENT_DYN_STAT(net_fastopen_failures_stat);
+ if (err > 0) {
--- End diff --
`>= 0`? or is 0 bytes sent not a success?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1061: TS-4903: EISCONN errors when using TCP Fas...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1061: TS-4903: EISCONN errors when using TCP Fast Open.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1061
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/896/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1061: TS-4903: EISCONN errors when using TCP Fast Open.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1061
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/898/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---