[GitHub] [incubator-heron] surahman commented on issue #3724: Management/Driver pod should not use the same resources as the other topology pods. Should create separate deployment/service.

[GitBox <gi...@apache.org>]

surahman commented on issue #3724:
URL: https://github.com/apache/incubator-heron/issues/3724#issuecomment-966399651


   That last issue should be simple enough:
   
   https://github.com/apache/incubator-heron/blob/4f588cfe003ee47264e564d25d694c1300d32fbc/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java#L345-L347
   
   becomes:
   
   ```java
     private static String setShardIdEnvironmentVariableCommand(boolean isExecutor) {
       final String pattern = String.format("%%s=%s && echo shardId=${%%s}",
           isExecutor ? "$((${POD_NAME##*-} + 1))" : "${POD_NAME##*-}");
       return String.format(pattern, ENV_SHARD_ID, ENV_SHARD_ID);
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org