You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by uncleGen <gi...@git.apache.org> on 2017/09/19 07:41:34 UTC

[GitHub] kafka pull request #3897: KAFKA-5929: Save pre-assignment to file to avoid t...

GitHub user uncleGen opened a pull request:

    https://github.com/apache/kafka/pull/3897

    KAFKA-5929: Save pre-assignment to file to avoid too long text to display when do topic partition reassign

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uncleGen/kafka KAFKA-5929

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3897
    
----
commit 9a78be366c3ad99f4418c6dab1c9701739b26c07
Author: 木艮 <ge...@alibaba-inc.com>
Date:   2017-09-19T07:40:09Z

    Save pre-assignment to file to avoid too long text to display when do topic partition reassign

----


---

[GitHub] kafka pull request #3897: KAFKA-5929: Save pre-assignment to file to avoid t...

Posted by uncleGen <gi...@git.apache.org>.
Github user uncleGen closed the pull request at:

    https://github.com/apache/kafka/pull/3897


---

[GitHub] kafka pull request #3897: KAFKA-5929: Save pre-assignment to file to avoid t...

Posted by uncleGen <gi...@git.apache.org>.
GitHub user uncleGen reopened a pull request:

    https://github.com/apache/kafka/pull/3897

    KAFKA-5929: Save pre-assignment to file to avoid too long text to display when do topic partition reassign

    When do partition reassign
    - before pr
    Pre-assignment will be printed directly. It is not friendly when the text is too long.
    
    - after pr
    Pre-assignment will still be printed directly, but will be save to a file at the same time, naming with suffix ".rollback" of "reassignment-json-file". For example:
    
    ```
    ./kafka-reassign-partitions.sh --reassignment-json-file test.json ...
    ```
    then we may get a file **test.json.rollback**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uncleGen/kafka KAFKA-5929

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3897
    
----
commit b5806c9f09459e473d6d1eb66c46a546c526d9c7
Author: uncleGen <hu...@gmail.com>
Date:   2017-09-19T07:40:09Z

    Save pre-assignment to file to avoid too long text to display when do topic partition reassign

commit 19d3f84a237c3a685d805f0974282734fcc8e655
Author: uncleGen <hu...@gmail.com>
Date:   2017-09-19T08:23:50Z

    findbugs fix

----


---