[GitHub] [pulsar-client-cpp] RobertIndie commented on a diff in pull request #253: PIP-254: Support configuring client version with a description suffix

["RobertIndie (via GitHub)" <gi...@apache.org>]

RobertIndie commented on code in PR #253:
URL: https://github.com/apache/pulsar-client-cpp/pull/253#discussion_r1169862182


##########
lib/ConnectionPool.h:
##########
@@ -41,7 +41,8 @@ using ExecutorServiceProviderPtr = std::shared_ptr<ExecutorServiceProvider>;
 class PULSAR_PUBLIC ConnectionPool {
    public:
     ConnectionPool(const ClientConfiguration& conf, ExecutorServiceProviderPtr executorProvider,
-                   const AuthenticationPtr& authentication, bool poolConnections = true);
+                   const AuthenticationPtr& authentication, bool poolConnections,

Review Comment:
   +1 for not using default value here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org