[geode-native] branch develop updated: GEODE-8842: Limit no-used-but-marked-unused to new integration tests (#723)

[bb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bbender pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git


The following commit(s) were added to refs/heads/develop by this push:
     new bc3fa6b  GEODE-8842: Limit no-used-but-marked-unused to new integration tests (#723)
bc3fa6b is described below

commit bc3fa6bffb5ffc476260db0820e83fdec3b341d2
Author: M. Oleske <mo...@users.noreply.github.com>
AuthorDate: Thu Jan 21 15:25:21 2021 -0800

    GEODE-8842: Limit no-used-but-marked-unused to new integration tests (#723)
    
    - SCOPED_TRACE in gtest causes this error, so only allow in that scope
    
    Authored-by: M. Oleske <mi...@oleske.engineer>
---
 CMakeLists.txt                           |  1 -
 cppcache/integration/test/CMakeLists.txt | 16 +++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 60fd2ed..68328fb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -241,7 +241,6 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     -Wextra
     -Wno-unused-variable #TODO fix
     -Wno-unused-function #TODO fix
-    -Wno-used-but-marked-unused #TODO fix
     -Wpedantic
     -Weverything
     -Wno-non-virtual-dtor #TODO fix
diff --git a/cppcache/integration/test/CMakeLists.txt b/cppcache/integration/test/CMakeLists.txt
index 3f1029b..9aa4109 100644
--- a/cppcache/integration/test/CMakeLists.txt
+++ b/cppcache/integration/test/CMakeLists.txt
@@ -16,6 +16,7 @@
 add_executable(cpp-integration-test
   AuthInitializeTest.cpp
   BasicIPv6Test.cpp
+  CacheWriterTest.cpp
   CacheXmlTest.cpp
   CleanIdleConnections.cpp
   ClientTransactionXATest.cpp
@@ -30,12 +31,13 @@ add_executable(cpp-integration-test
   FunctionExecutionTest.cpp
   LRUEvictionTest.cpp
   LocatorRequestsTest.cpp
+  Order.cpp
+  Order.hpp
   PartitionRegionOpsTest.cpp
+  PdxInstanceFactoryTest.cpp
   PdxInstanceTest.cpp
   PdxJsonTypeTest.cpp
   PdxSerializerTest.cpp
-  Order.cpp
-  Order.hpp
   Position.cpp
   Position.hpp
   PositionKey.cpp
@@ -53,11 +55,15 @@ add_executable(cpp-integration-test
   SslTwoWayTest.cpp
   StructTest.cpp
   TransactionCleaningTest.cpp
-  WanDeserializationTest.cpp
-  PdxInstanceFactoryTest.cpp
-  CacheWriterTest.cpp
   TransactionsTest.cpp
+  WanDeserializationTest.cpp
 )
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  target_compile_options(cpp-integration-test
+    PUBLIC
+      -Wno-used-but-marked-unused
+  )
+endif()
 
 target_compile_definitions(cpp-integration-test
   PUBLIC