You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/12/16 21:36:28 UTC
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14913
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
IMPALA-9248: fix test_krpc_rpcz on older kernels
Switched the test to check a different counter that
is present in the 2.6.32 kernel (see
https://kernel.googlesource.com/pub/scm/linux/kernel/git/vapier/lemote/+/linux-2.6.32-stable/include/linux/tcp.h)
Testing:
Ran the affected test on a CentOS 6 system.
Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
---
M tests/webserver/test_web_pages.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/14913/1
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 20:13:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
IMPALA-9248: fix test_krpc_rpcz on older kernels
Switched the test to check a different counter that
is present in the 2.6.32 kernel (see
https://kernel.googlesource.com/pub/scm/linux/kernel/git/vapier/lemote/+/linux-2.6.32-stable/include/linux/tcp.h)
Testing:
Ran the affected test on a CentOS 6 system.
Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Reviewed-on: http://gerrit.cloudera.org:8080/14913
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 19:49:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5353/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 20:13:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Dec 2019 00:41:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9248: fix test krpc rpcz on older kernels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14913 )
Change subject: IMPALA-9248: fix test_krpc_rpcz on older kernels
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5292/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40aece9d37622710a4ef3add2b1088bb3ac91563
Gerrit-Change-Number: 14913
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 22:06:58 +0000
Gerrit-HasComments: No