[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11661: fix (dashboard): remove default filters parameters from dashboard url

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #11661:
URL: https://github.com/apache/incubator-superset/pull/11661#issuecomment-726216628


   > [totally outside the scope of this PR] I really think we should use `rison` in more places now that we use it in the API backend systematically. urlencoded JSON really doesn't look good!
   
   I agree internally use `rison` in more places, but do we still want to support `urlencoded`? In currently in dashboard initialization, we only parse `urlencoded` url parameters. I knew some users (in airbnb) use script generate dashboard url, they probably are not familiar with `rison` yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org