You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/27 05:46:01 UTC

[jira] [Work logged] (GOBBLIN-1373) remove fixed sleep time in HighLevelConsumer

     [ https://issues.apache.org/jira/browse/GOBBLIN-1373?focusedWorklogId=542662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542662 ]

ASF GitHub Bot logged work on GOBBLIN-1373:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/21 05:45
            Start Date: 27/Jan/21 05:45
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on pull request #3215:
URL: https://github.com/apache/incubator-gobblin/pull/3215#issuecomment-768046999


   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=h1) Report
   > Merging [#3215](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=desc) (0bfd18c) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f4c75139bf38b73b3fc052cc5c2010cdca9bc4c0?el=desc) (f4c7513) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #3215      +/-   ##
   ===========================================
   - Coverage      9.17%   9.16%   -0.01%     
   + Complexity     1738    1736       -2     
   ===========================================
     Files          2019    2019              
     Lines         77506   77515       +9     
     Branches       8607    8608       +1     
   ===========================================
   - Hits           7109    7106       -3     
   - Misses        69701   69714      +13     
   + Partials        696     695       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rg/apache/gobblin/cluster/GobblinClusterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJVdGlscy5qYXZh) | `35.18% <0.00%> (-17.60%)` | `9.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `29.93% <0.00%> (-0.66%)` | `24.00% <0.00%> (-1.00%)` | |
   | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `61.53% <0.00%> (-0.65%)` | `32.00% <0.00%> (-1.00%)` | |
   | [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...li/GobblinServiceFlowExecutionResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93RXhlY3V0aW9uUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rg/apache/gobblin/service/FlowExecutionClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93RXhlY3V0aW9uQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../apache/gobblin/service/FlowExecutionResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93RXhlY3V0aW9uUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3215/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (+7.14%)` | `3.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=footer). Last update [f4c7513...d4f8237](https://codecov.io/gh/apache/incubator-gobblin/pull/3215?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 542662)
    Remaining Estimate: 0h
            Time Spent: 10m

> remove fixed sleep time in HighLevelConsumer
> --------------------------------------------
>
>                 Key: GOBBLIN-1373
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1373
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HighLevelConsumer thread sleeps for 50ms after doing a poll. This significantly reduces its speed of consumption.
> Removing this wait time can be a big improvement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)