You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 15:30:05 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #8992:
[WIP] Bump requirements.txt
villebro opened a new pull request #8992: [WIP] Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
The current pinned dependencies are to some degree getting stale and far away from `setup.py`, and are causing trouble with some stable `sqlalchemy` dialect versions, namely `snowflake-sqlalchemy` which currently requires `asn1crypto>0.24`. The good news is that bumping `cryptography` from `2.7` to `2.8` removes the `asn1crypto` dependency all together. This has been tested locally to work well, and doesn't seem to contain any dramatic updates.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8992: chore:
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on issue #8992:
chore: Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577461449
BTW, not sure if people know about https://requires.io/github/mistercrunch/superset/requirements/?branch=master
This is pointing to my fork ATM, but we should ask the ASF infra to click the button to activate the root repo for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8992: chore:
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577760039
π’
<img width="917" alt="Screen Shot 2020-01-23 at 8 26 13 AM" src="https://user-images.githubusercontent.com/487433/73003468-90c0fe80-3dba-11ea-9476-56bd1aef8cd8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8992: [WIP]
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8992: [WIP] Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577245842
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=h1) Report
> Merging [#8992](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e46ff239afc79af5753cfe82779fa87796f46a27?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8992 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 367 367
Lines 11679 11679
Branches 2862 2862
=======================================
Hits 6910 6910
Misses 4590 4590
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=footer). Last update [e46ff23...99bc6c1](https://codecov.io/gh/apache/incubator-superset/pull/8992?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8992: chore:
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577461449
BTW, not sure if people know about https://requires.io/github/mistercrunch/superset/requirements/?branch=endpoints .
This is pointing to my fork ATM, but we should ask the ASF infra to click the button to activate the root repo for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8992: chore: Bump
requirements.txt
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577502603
Adding `requires.io` would be great, as it would make it much easier to regularly keep deps up to date π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on issue #8992:
chore: Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577461449
BTW, not sure if people know about https://requires.io/github/mistercrunch/superset/requirements/?branch=master
This is pointing to my fork ATM, but we should ask the ASF infra to click the button to activate the root repo for us.
Oh and there's this https://david-dm.org/apache/incubator-superset?path=superset/assets, this one we have the badge for on our `README.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8992: chore:
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577466939
Created a ticket with ASF infra to enable requires.io here:
https://issues.apache.org/jira/browse/INFRA-19753
Once it's done we can add the corresponding badge to our `README.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8992: chore:
Bump requirements.txt
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8992: chore: Bump requirements.txt
URL: https://github.com/apache/incubator-superset/pull/8992#issuecomment-577869468
For the record though, it's not as great but you can use requires.io on a need basis against any public fork. We may have `master` synced/mirrored through a bot/hooks on our `preset-io` org, or could do it on the `apache-superset` org and point requries.io to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org