You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/21 20:06:57 UTC

[GitHub] [beam] lukecwik opened a new pull request #11483: Revert "[BEAM-9014] CachingShuffleBatchReader use bytes to limit cache size."

lukecwik opened a new pull request #11483:
URL: https://github.com/apache/beam/pull/11483


   This change negatively impacts shuffle performance for large iterables.
   
   R: @tudorm @tysonjh 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tudorm commented on issue #11483: Revert "[BEAM-9014] CachingShuffleBatchReader use bytes to limit cache size."

Posted by GitBox <gi...@apache.org>.
tudorm commented on issue #11483:
URL: https://github.com/apache/beam/pull/11483#issuecomment-617396056


   lgtm


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on issue #11483: Revert "[BEAM-9014] CachingShuffleBatchReader use bytes to limit cache size."

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11483:
URL: https://github.com/apache/beam/pull/11483#issuecomment-617386847


   CC: @ibzib Another change to cherrypick into release 2.21 if possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org