You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:37:39 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix
fynmanoj opened a new pull request #1209:
URL: https://github.com/apache/fineract/pull/1209
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
https://mifosforge.jira.com/browse/AL-2
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1209:
URL: https://github.com/apache/fineract/pull/1209#issuecomment-667540215
We are planning to move all the tickets to fineract tracker, and I will
correct the PR issues parallelly
On Sat, 1 Aug, 2020, 19:44 Michael Vorburger ⛑️, <no...@github.com>
wrote:
> @fynmanoj <https://github.com/fynmanoj> this PR needs to have a JIRA
> issue on the ASF JIRA, instead of referencing an issue on
> https://mifosforge.jira.com.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1209#issuecomment-667538338>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANQLL2W5UMCPED3B7XJRWPDR6QPKZANCNFSM4PLWWUPQ>
> .
>
--
Disclaimer:
Privileged & confidential information is contained in this
message (including all attachments). If you are not an intended recipient
of this message, please destroy this message immediately and kindly notify
the sender by reply e-mail. Any unauthorised use or dissemination of this
message in any manner whatsoever, in whole or in part, is strictly
prohibited. This e-mail, including all attachments hereto, (i) is for
discussion purposes only and shall not be deemed or construed to be a
professional opinion unless expressly stated otherwise, and (ii) is not
intended, written or sent to be used, and cannot and shall not be used, for
any unlawful purpose. This communication, including any attachments, may
not be free of viruses, interceptions or interference, and may not be
compatible with your systems. You should carry out your own virus checks
before opening any attachment to this e-mail. The sender of this e-mail and
*Fynarfin Tech Private Limited* shall not be liable for any damage that
you may sustain as a result of viruses, incompleteness of this message, a
delay in receipt of this message or computer problems experienced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1209:
URL: https://github.com/apache/fineract/pull/1209#issuecomment-667538338
@fynmanoj this PR needs to have a JIRA issue on the ASF JIRA, instead of referencing an issue on https://mifosforge.jira.com.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1209: AL-2-reschedule-loan-first-pay-day-holiday-fix
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1209:
URL: https://github.com/apache/fineract/pull/1209#issuecomment-667538085
@avikganguly01 knowing that @fynmanoj works with you, and assuming that you are still an active committer to this project (are you?), I was wondering if you would like to engage on code review feedback and possible evental merge of PRs such as this one? (I don't want to be a bottleneck on this project, and won't have the spare time to help review changes like this. If there are other active commiters such as @awasum @ptuomola @xurror or others reading this who want to engage on this PR, please don't let me hold you up / wait for me - I'll ignore this one, and try to help on others.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1209: FINERACT-1106 reschedule-loan-first-pay-day-holiday-fix
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1209:
URL: https://github.com/apache/fineract/pull/1209#issuecomment-671524425
@vorburger I opened up tickets on JIRA for these pull requests and referenced them in the title of the PR. I tagged @avikganguly01 as a reviewer and assume he can do the needful in reviewing and merging the PRs as we are going to start testing this development branch with these pull requests merged on the user's test server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1209: FINERACT-1106 reschedule-loan-first-pay-day-holiday-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1209:
URL: https://github.com/apache/fineract/pull/1209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org