You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Vandahl (JIRA)" <ji...@apache.org> on 2016/07/26 16:22:20 UTC
[jira] [Commented] (TORQUE-344) Update to Commons Pool/DBCP Version
2
[ https://issues.apache.org/jira/browse/TORQUE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394032#comment-15394032 ]
Thomas Vandahl commented on TORQUE-344:
---------------------------------------
I'd rather make both dependencies optional and document this accordingly. I'll try to fiddle something with a maven profile.
> Update to Commons Pool/DBCP Version 2
> -------------------------------------
>
> Key: TORQUE-344
> URL: https://issues.apache.org/jira/browse/TORQUE-344
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Affects Versions: 4.1
> Reporter: Georg Kallidis
> Assignee: Thomas Vandahl
>
> Support for Apache Commons Pool Version 2 (since 2013, current verson 2.4.2) and Apache Commons DBCP2 features (since 2014, current version 2.1.1).
> Caveat: Commons Pool 2 requires Java 1.6, but DBCP 2 Java 1.7.
> Code changes seem to be minimal in only a few dsfactory classes. Maybe the easiest way to support version 2 pool/dbcp is to allow for another module runtime2 with appropriate dependencies?
> e.g. ...
> <dependency>
> <groupId>org.apache.torque</groupId>
> <artifactId>torque-runtime</artifactId>
> <version>${project.version}</version>
> <exclusions>
> <exclusion>
> <groupId>commons-dbcp</groupId>
> <artifactId>commons-dbcp</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.apache.commons</groupId>
> <artifactId>commons-dbcp2</artifactId>
> <version>2.1.1</version>
> </dependency>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org