You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/23 03:30:03 UTC
[GitHub] [spark] WangGuangxin commented on a change in pull request #35460: [SPARK-38160][SQL] Shuffle by rand could lead to incorrect answers when ShuffleFetchFailed happend
WangGuangxin commented on a change in pull request #35460:
URL: https://github.com/apache/spark/pull/35460#discussion_r812533440
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -401,6 +405,29 @@ object ShuffleExchangeExec {
dependency
}
+ /**
+ * Checks if the shuffle partitioning contains indeterminate expression/reference.
+ */
+ private def isPartitioningIndeterminate(partitioning: Partitioning, plan: SparkPlan): Boolean = {
Review comment:
You mean the QueryPlan's `deterministic`? https://github.com/apache/spark/pull/34470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org