You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "adrianiacobghiula (via GitHub)" <gi...@apache.org> on 2024/03/01 10:26:42 UTC

[I] allow override the Schema Creator by a consumer [pulsar-client-go]

adrianiacobghiula opened a new issue, #1191:
URL: https://github.com/apache/pulsar-client-go/issues/1191

   **Is your feature request related to a problem? Please describe.**
   A consumer should be allowed to select / choose / override the default Schema. For example select to use https://github.com/hamba/avro and not github.com/linkedin/goavro/v2 
   
   **Describe the solution you'd like**
   Allow the consumer in Options to set a different function as SchemaCreator
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] allow override the Schema Creator by a consumer [pulsar-client-go]

Posted by "adrianiacobghiula (via GitHub)" <gi...@apache.org>.
adrianiacobghiula commented on issue #1191:
URL: https://github.com/apache/pulsar-client-go/issues/1191#issuecomment-1976350397

   @RobertIndie  thanks for looking at the PR 
   I choose to use hamba because of avro to golang struct generation -> see avrogen.
   Easier handling of "nullable" union. by having a field as pointer. 
   benchmark shows to be faster than linkedin.
   There is a minus that hopefully with later versions can be covered: recursive structs not not covered.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] allow override the Schema Creator by a consumer [pulsar-client-go]

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on issue #1191:
URL: https://github.com/apache/pulsar-client-go/issues/1191#issuecomment-1976278163

   Can you highlight the benefits of using https://github.com/hamba/avro? Given that https://github.com/linkedin/goavro has yet to see updates in 2 years, it might be worthwhile considering replacing it with https://github.com/hamba/avro if we have compelling reasons.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] allow override the Schema Creator by a consumer [pulsar-client-go]

Posted by "adrianiacobghiula (via GitHub)" <gi...@apache.org>.
adrianiacobghiula closed issue #1191: allow override the Schema Creator by a consumer
URL: https://github.com/apache/pulsar-client-go/issues/1191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org