You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/06/19 14:06:12 UTC
[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/491
findbugs: repeated condition seems c&p error
the tested states sugest that EXPUNGED should be the last one. Might be that it can be removed altogether instead.
@mike-tutkowski @bhaisaab @sanjaytripathi and maybe others; you know better then me!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack findbugs-RpC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #491
----
commit aa61c81b24c34c592e0e1549d0a35d1317b5938c
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-06-19T12:02:13Z
findbugs: repeated condition seems c&p error
the tested states sugest that EXPUNGED should be the last one
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/491#issuecomment-113498905
@DaanHoogland looks like you're right, we should be trying to delete a volume that is already destroyed, expunged or is being expunged. LGTM, merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---