You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/03/18 11:11:12 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/784
ZEPPELIN-748 make websocket maxTextMessageSize configurable
### What is this PR for?
Allow the user to modify the value for websocket maxTextMessageSize via conf. Recently a user filed an issue asking for the size to be configurable.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-748](https://issues.apache.org/jira/browse/ZEPPELIN-748)
### How should this be tested?
modify the value for maxTextMessageSize in zeppelin-site.xml or zeppelin-env.sh
### Screenshots (if appropriate)
<img width="990" alt="screen shot 2016-03-18 at 3 35 19 pm" src="https://cloud.githubusercontent.com/assets/2031306/13874611/1297844c-ed1f-11e5-8512-7307f6c4177d.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes. updated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin ZEPPELIN-748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #784
----
commit a7cb05bbb8685ced0b671248756165d1af802fef
Author: Renjith Kamath <re...@gmail.com>
Date: 2016-03-18T09:54:17Z
ZEPPELIN-748 make websocket maxTextMessageSize configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/784#issuecomment-198444595
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/784#issuecomment-202166680
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-748 make websocket maxTe...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/784#issuecomment-198630663
Tested, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---