You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gora.apache.org by le...@apache.org on 2011/10/31 16:01:20 UTC
svn commit: r1195499 -
/incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
Author: lewismc
Date: Mon Oct 31 15:01:20 2011
New Revision: 1195499
URL: http://svn.apache.org/viewvc?rev=1195499&view=rev
Log:
removal of HBaseStore thread-safe comment in HBaseStore.java
Modified:
incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
Modified: incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
URL: http://svn.apache.org/viewvc/incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java?rev=1195499&r1=1195498&r2=1195499&view=diff
==============================================================================
--- incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java (original)
+++ incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java Mon Oct 31 15:01:20 2011
@@ -76,7 +76,6 @@ import org.jdom.input.SAXBuilder;
/**
* DataStore for HBase.
*
- * <p> Note: HBaseStore is not yet thread-safe.
*/
public class HBaseStore<K, T extends Persistent> extends DataStoreBase<K, T>
implements Configurable {
Re: svn commit: r1195499 - /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
Posted by Enis Söztutar <en...@gmail.com>.
Hi Lewis,
Thanks for reverting this. No worries at all, version control is there so
that we can use it :)
Thanks,
Enis
On Tue, Nov 1, 2011 at 4:54 AM, Lewis John Mcgibbney <
lewis.mcgibbney@gmail.com> wrote:
> Hi All,
>
> I've reverted the trivial change I made to the codebase and committed @
> revision 1195940 in trunk.
>
> I apologise for this, it was a lapse of concentration. I thought things had
> moved on further than they have.
>
> Again apologies
>
> Lewis
>
>
> On Mon, Oct 31, 2011 at 11:33 PM, Enis Söztutar <en...@gmail.com>
> wrote:
>
> > Lewis, GORA-56 is not committed yet, why did you remove the javadoc? The
> > patch already does remove it.
> >
> > Enis
> >
> > On Mon, Oct 31, 2011 at 8:01 AM, <le...@apache.org> wrote:
> >
> > > Author: lewismc
> > > Date: Mon Oct 31 15:01:20 2011
> > > New Revision: 1195499
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1195499&view=rev
> > > Log:
> > > removal of HBaseStore thread-safe comment in HBaseStore.java
> > >
> > > Modified:
> > >
> > >
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > >
> > > Modified:
> > >
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java?rev=1195499&r1=1195498&r2=1195499&view=diff
> > >
> > >
> >
> ==============================================================================
> > > ---
> > >
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > > (original)
> > > +++
> > >
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > > Mon Oct 31 15:01:20 2011
> > > @@ -76,7 +76,6 @@ import org.jdom.input.SAXBuilder;
> > > /**
> > > * DataStore for HBase.
> > > *
> > > - * <p> Note: HBaseStore is not yet thread-safe.
> > > */
> > > public class HBaseStore<K, T extends Persistent> extends
> > DataStoreBase<K,
> > > T>
> > > implements Configurable {
> > >
> > >
> > >
> >
>
>
>
> --
> *Lewis*
>
Re: svn commit: r1195499 - /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi All,
I've reverted the trivial change I made to the codebase and committed @
revision 1195940 in trunk.
I apologise for this, it was a lapse of concentration. I thought things had
moved on further than they have.
Again apologies
Lewis
On Mon, Oct 31, 2011 at 11:33 PM, Enis Söztutar <en...@gmail.com> wrote:
> Lewis, GORA-56 is not committed yet, why did you remove the javadoc? The
> patch already does remove it.
>
> Enis
>
> On Mon, Oct 31, 2011 at 8:01 AM, <le...@apache.org> wrote:
>
> > Author: lewismc
> > Date: Mon Oct 31 15:01:20 2011
> > New Revision: 1195499
> >
> > URL: http://svn.apache.org/viewvc?rev=1195499&view=rev
> > Log:
> > removal of HBaseStore thread-safe comment in HBaseStore.java
> >
> > Modified:
> >
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> >
> > Modified:
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java?rev=1195499&r1=1195498&r2=1195499&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > (original)
> > +++
> >
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> > Mon Oct 31 15:01:20 2011
> > @@ -76,7 +76,6 @@ import org.jdom.input.SAXBuilder;
> > /**
> > * DataStore for HBase.
> > *
> > - * <p> Note: HBaseStore is not yet thread-safe.
> > */
> > public class HBaseStore<K, T extends Persistent> extends
> DataStoreBase<K,
> > T>
> > implements Configurable {
> >
> >
> >
>
--
*Lewis*
Re: svn commit: r1195499 - /incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
Posted by Enis Söztutar <en...@gmail.com>.
Lewis, GORA-56 is not committed yet, why did you remove the javadoc? The
patch already does remove it.
Enis
On Mon, Oct 31, 2011 at 8:01 AM, <le...@apache.org> wrote:
> Author: lewismc
> Date: Mon Oct 31 15:01:20 2011
> New Revision: 1195499
>
> URL: http://svn.apache.org/viewvc?rev=1195499&view=rev
> Log:
> removal of HBaseStore thread-safe comment in HBaseStore.java
>
> Modified:
>
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
>
> Modified:
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> URL:
> http://svn.apache.org/viewvc/incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java?rev=1195499&r1=1195498&r2=1195499&view=diff
>
> ==============================================================================
> ---
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> (original)
> +++
> incubator/gora/trunk/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
> Mon Oct 31 15:01:20 2011
> @@ -76,7 +76,6 @@ import org.jdom.input.SAXBuilder;
> /**
> * DataStore for HBase.
> *
> - * <p> Note: HBaseStore is not yet thread-safe.
> */
> public class HBaseStore<K, T extends Persistent> extends DataStoreBase<K,
> T>
> implements Configurable {
>
>
>