You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 05:28:39 UTC

[GitHub] [airflow] brandondtb commented on a change in pull request #13299: fix 422 invalid value error caused by long k8s pod name

brandondtb commented on a change in pull request #13299:
URL: https://github.com/apache/airflow/pull/13299#discussion_r552377212



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -370,6 +368,10 @@ def construct_pod(  # pylint: disable=too-many-arguments
         except Exception:  # pylint: disable=W0703
             image = kube_image
 
+        task_id = make_safe_label_value(task_id)
+        dag_id = make_safe_label_value(dag_id)
+        scheduler_job_id = make_safe_label_value(scheduler_job_id)

Review comment:
       @houqp `scheduler_job_id` needs to be converted to a string.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org