You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Fero Szabo via Review Board <no...@reviews.apache.org> on 2018/03/14 11:15:05 UTC
Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/
-----------------------------------------------------------
Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
Bugs: SQOOP-3292
https://issues.apache.org/jira/browse/SQOOP-3292
Repository: sqoop-trunk
Description
-------
Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
Also fixed 2 typos.
Diffs
-----
src/docs/user/import.txt 330d5445
Diff: https://reviews.apache.org/r/66062/diff/1/
Testing
-------
Thanks,
Fero Szabo
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/#review199658
-----------------------------------------------------------
Hi Feró,
Thank you for improving our documentation!
The content looks good to me, there is only one sytax error you need to fix and we can commmit it.
Szabolcs
src/docs/user/import.txt
Lines 802 (patched)
<https://reviews.apache.org/r/66062/#comment280030>
This should be removed otherwise ant docs throws this error:
asciidoc: ERROR: import.txt: line 810: [blockdef-listing] missing closing delimiter
- Szabolcs Vasas
On March 14, 2018, 11:15 a.m., Fero Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66062/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 11:15 a.m.)
>
>
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3292
> https://issues.apache.org/jira/browse/SQOOP-3292
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
>
> I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
>
> Also fixed 2 typos.
>
>
> Diffs
> -----
>
> src/docs/user/import.txt 330d5445
>
>
> Diff: https://reviews.apache.org/r/66062/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fero Szabo
>
>
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/#review199535
-----------------------------------------------------------
Ship it!
Ship It!
- Boglarka Egyed
On March 14, 2018, 11:15 a.m., Fero Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66062/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 11:15 a.m.)
>
>
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3292
> https://issues.apache.org/jira/browse/SQOOP-3292
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
>
> I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
>
> Also fixed 2 typos.
>
>
> Diffs
> -----
>
> src/docs/user/import.txt 330d5445
>
>
> Diff: https://reviews.apache.org/r/66062/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fero Szabo
>
>
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/#review199668
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On March 21, 2018, 1:42 p.m., Fero Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66062/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 1:42 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3292
> https://issues.apache.org/jira/browse/SQOOP-3292
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
>
> I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
>
> Also fixed 2 typos.
>
>
> Diffs
> -----
>
> COMPILING.txt 86be5094
> src/docs/user/import.txt 330d5445
>
>
> Diff: https://reviews.apache.org/r/66062/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fero Szabo
>
>
Re: Review Request 66062: SQOOP-3293 Documentation for avro padding
(SQOOP-2976)
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/
-----------------------------------------------------------
(Updated March 22, 2018, 4:25 p.m.)
Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
Summary (updated)
-----------------
SQOOP-3293 Documentation for avro padding (SQOOP-2976)
Bugs: SQOOP-3293
https://issues.apache.org/jira/browse/SQOOP-3293
Repository: sqoop-trunk
Description
-------
Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
Also fixed 2 typos.
Diffs
-----
COMPILING.txt 86be5094
src/docs/user/import.txt 330d5445
Diff: https://reviews.apache.org/r/66062/diff/3/
Testing
-------
Thanks,
Fero Szabo
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/
-----------------------------------------------------------
(Updated March 21, 2018, 1:42 p.m.)
Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
Changes
-------
Thanks Szabi!
I added this information to COMPILING.txt
Bugs: SQOOP-3292
https://issues.apache.org/jira/browse/SQOOP-3292
Repository: sqoop-trunk
Description
-------
Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
Also fixed 2 typos.
Diffs (updated)
-----
COMPILING.txt 86be5094
src/docs/user/import.txt 330d5445
Diff: https://reviews.apache.org/r/66062/diff/3/
Changes: https://reviews.apache.org/r/66062/diff/2-3/
Testing
-------
Thanks,
Fero Szabo
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/#review199659
-----------------------------------------------------------
Ship it!
Oh yes, this error looks familiar, the workaround is to export XML_CATALOG_FILES:
export XML_CATALOG_FILES=/usr/local/etc/xml/catalog
It might have been resolved in newer versions of asciidoc (https://github.com/mawww/kakoune/issues/963) but it would be good if we could have it documented in our docs.
- Szabolcs Vasas
On March 21, 2018, 1:20 p.m., Fero Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66062/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 1:20 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3292
> https://issues.apache.org/jira/browse/SQOOP-3292
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
>
> I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
>
> Also fixed 2 typos.
>
>
> Diffs
> -----
>
> src/docs/user/import.txt 330d5445
>
>
> Diff: https://reviews.apache.org/r/66062/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fero Szabo
>
>
Re: Review Request 66062: SQOOP-3292 Documentation for avro padding
(SQOOP-2976)
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66062/
-----------------------------------------------------------
(Updated March 21, 2018, 1:20 p.m.)
Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
Changes
-------
Hi Szabi,
I removed the line you mentioned, but now I get the following error (probably because of a bad env setup):
real-docs:
[exec] asciidoc --unsafe -b docbook -d manpage -a "author=Sqoop Team" man/sqoop-codegen.txt
[exec] /bin/sh: lsb_release: command not found
[exec] xmlto man man/sqoop-codegen.xml -o man
[exec] xmlto: /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml does not validate (status 3)
[exec] xmlto: Fix document syntax or use --skip-validation option
[exec] I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
[exec] /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml:2: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
[exec] D DocBook XML V4.5//EN" "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
[exec] ^
[exec] I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
[exec] warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
[exec] validity error : Could not load the external subset "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
[exec] Document /Users/ferencszabo/workspace/sqoop/src/docs/man/sqoop-codegen.xml does not validate
[exec] make: *** [man/sqoop-codegen.1.gz] Error 13
Do you happen to know what the problem might be?
In any case, this might warrant a fix in another Jira..
Bugs: SQOOP-3292
https://issues.apache.org/jira/browse/SQOOP-3292
Repository: sqoop-trunk
Description
-------
Documentation for avro decimal padding i.e. the sqoop.avro.logical_types.decimal.enable flag.
I also added a few lines to mention sqoop.avro.logical_types.decimal.enable, because the two goes hand in hand.
Also fixed 2 typos.
Diffs (updated)
-----
src/docs/user/import.txt 330d5445
Diff: https://reviews.apache.org/r/66062/diff/2/
Changes: https://reviews.apache.org/r/66062/diff/1-2/
Testing
-------
Thanks,
Fero Szabo