[GitHub] mike-jumper commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

[GitBox <gi...@apache.org>]

mike-jumper commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module
URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456664784
 
 
   > The reason why there are interfaces and empty classes is being able to share the code in a generic way with the extension of Morphia/MongoDB, since the data structure is not exactly the same because the relationships between entities are done by objects.
   
   Empty classes/interfaces are definitely an antipattern. If something about the design of the MongoDB extension is requiring this, that suggests something needs to be addressed in the overall design. It shouldn't be necessary, and the needs of the specific Morphia/MongoDB implementation shouldn't be the guiding factor of the generic extraction of the a permission implementation.
   
   The presence of models in the generic part of this is also a sign that things should be rethought. The models underlying these objects (or if there even are models) should be a concern of the implementation leveraging the generic permission / connection tracking library, not the library itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services