You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/10/27 13:40:11 UTC
[GitHub] [incubator-doris] imay commented on a change in pull request #2079:
Multi distinct + no group by + big data is struct
imay commented on a change in pull request #2079: Multi distinct + no group by + big data is struct
URL: https://github.com/apache/incubator-doris/pull/2079#discussion_r339343319
##########
File path: be/src/service/brpc_service.h
##########
@@ -18,10 +18,12 @@
#pragma once
#include <memory>
-
+#include "service/brpc.h"
Review comment:
You'd better not include this file in `.h` file, because it will make other files which include this file will include `service/brpc.h`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org