You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/03 23:31:05 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #8109: ARROW-9913: [C++] Make outputs of Decimal128::FromString independent of the presence of one another.

emkornfield commented on a change in pull request #8109:
URL: https://github.com/apache/arrow/pull/8109#discussion_r483305734



##########
File path: cpp/src/arrow/util/decimal_test.cc
##########
@@ -113,7 +113,7 @@ TEST(DecimalTest, TestStringRoundTrip) {
       (1ull << 63),
       std::numeric_limits<uint64_t>::max(),
   };
-  static constexpr int32_t kScales[] = {-10, -1, 0, 1, 10};
+  static constexpr int32_t kScales[] = {0, 1, 10};

Review comment:
       would it make sense to add another test how this code behaves when scale is negative or is that already tested elsewhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org