You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/14 15:43:56 UTC
[GitHub] [iceberg] pan3793 opened a new pull request #4118: Spark: Align Antlr version with Spark
pan3793 opened a new pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118
Fix #4116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806207519
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
It seems like according to the comments in the build file that this should be shaded.
I'm guessing that the two still don't play nicely together? We might want to update some of the notes about shading the antlr runtime, as the comments make it seem like we don't need to worry about version conflicts with Spark (but the issue indicates we likely do).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1039643427
Can we get confirmation on the original issue? I haven't seen this locally yet, any chance the user submitting the bug has another Iceberg dep on the classpath?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1046194306
> The changes look good, but this affects the LICENSE files as well. Can you remove the ANTLR section from the spark-runtime LICENSE files?
Thanks for review, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1046281073
Thanks, @pan3793!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1041826295
> @RussellSpitzer If we relocate correctly, I think it should not occur in the runtime jar, but the conflict should occur in unit tests. Anyway, since we split the spark module, I think we'd better align the version with spark and exclude it from the runtime jar. WDYT?
I have no problem with just aligning and excluding now that we have a Spark Module per major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1039643427
Can we get confirmation on the original issue? I haven't seen this locally yet, any chance the user submitting the bug has another Iceberg dep on the classpath?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806312499
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I don't think that we shade antlr. I saw a conflict warning about this as well. @kbendick, what comment made you think that we are shading antlr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806296041
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
Yeah I wouldn't think this would be an issue except in the unshaded build, that said this is fine to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806314181
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I guess it’s just in the runtime jar that we shade. The comment above and then this one (which applies to the runtime jar): https://github.com/apache/iceberg/blob/25150e5ceb7c84a6dae773a12a5061edb55f2c8b/spark/v3.1/build.gradle#L253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806382125
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I remember we shaded antlr because we choose to make spark3-runtime support both spark 3.0/3.1, and they bundle the different version of antlr, since we split spark runtime jar by minor spark version, we can exclude antlr and avoid shading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806207519
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
It seems like according to the comments in the build file that this should be shaded.
I'm guessing that the two still don't play nicely together? We might want to update some of the notes about shading the antlr runtime, as the comments make it seem like we don't need to worry about version conflicts with Spark (but the issue indicates we likely do).
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I guess it’s just in the runtime jar that we shade. The comment above and then this one: https://github.com/apache/iceberg/blob/25150e5ceb7c84a6dae773a12a5061edb55f2c8b/spark/v3.1/build.gradle#L253
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I guess it’s just in the runtime jar that we shade. The comment above and then this one (which applies to the runtime jar): https://github.com/apache/iceberg/blob/25150e5ceb7c84a6dae773a12a5061edb55f2c8b/spark/v3.1/build.gradle#L253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806382125
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I remember we shaded antlr because we choose to make spark3-runtime support both spark 3.0/3.1, and they bundle the different version of antlr, since we split spark runtime jar by minor version, we can exclude antlr and avoid shading.
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I remember we shaded antlr because we choose to make spark3-runtime support both spark 3.0/3.1, and they bundle the different version of antlr, since we split spark runtime jar by minor spark version, we can exclude antlr and avoid shading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806296041
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
Yeah I wouldn't think this would be an issue except in the unshaded build, that said this is fine to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1046105674
The changes look good, but this affects the LICENSE files as well. Can you remove the ANTLR section from the spark-runtime LICENSE files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r808518026
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
Thanks for the context, @pan3793! I forgot that we had started shading Antlr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1042383593
I agree. Let's remove the dependency and use the one from Spark. Looks like we were incorrectly shading anyway because we didn't relocate the classes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #4118: Spark: Align Antlr version with Spark and exclude Antlr from Spark runtime jars
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#issuecomment-1041824799
@RussellSpitzer If we relocate correctly, I think it should not occur in the runtime jar, but the conflict should occur in unit tests. Anyway, since we split the spark module, I think we'd better align the version with spark and exclude it from the runtime jar. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806314181
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I guess it’s just in the runtime jar that we shade. The comment above and then this one: https://github.com/apache/iceberg/blob/25150e5ceb7c84a6dae773a12a5061edb55f2c8b/spark/v3.1/build.gradle#L253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806312499
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I don't think that we shade antlr. I saw a conflict warning about this as well. @kbendick, what comment made you think that we are shading antlr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #4118: Spark: Align Antlr version with Spark
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #4118:
URL: https://github.com/apache/iceberg/pull/4118#discussion_r806382125
##########
File path: spark/v3.1/build.gradle
##########
@@ -152,8 +152,8 @@ project(":iceberg-spark:iceberg-spark-extensions-3.1_2.12") {
// Required because we remove antlr plugin dependencies from the compile configuration, see note above
// We shade this in Spark3 Runtime to avoid issues with Spark's Antlr Runtime
- runtimeOnly "org.antlr:antlr4-runtime:4.7.1"
- antlr "org.antlr:antlr4:4.7.1"
+ runtimeOnly "org.antlr:antlr4-runtime:4.8"
+ antlr "org.antlr:antlr4:4.8"
Review comment:
I remember we shaded antlr because we choose to make spark3-runtime support both spark 3.0/3.1, and they bundle the different version of antlr, since we split spark runtime jar by minor version, we can exclude antlr and avoid shading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org