You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/03/08 15:09:18 UTC

svn commit: r634970 - in /maven/plugin-tools/trunk/maven-plugin-plugin/src/main: java/org/apache/maven/plugin/plugin/PluginReport.java resources/plugin-report.properties resources/plugin-report_de.properties resources/plugin-report_fr.properties

Author: vsiveton
Date: Sat Mar  8 06:09:17 2008
New Revision: 634970

URL: http://svn.apache.org/viewvc?rev=634970&view=rev
Log:
MPLUGIN-91: misleading icon on list of goals

o replaced icons by yes/no

Modified:
    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report.properties
    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_de.properties
    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_fr.properties

Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java?rev=634970&r1=634969&r2=634970&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java Sat Mar  8 06:09:17 2008
@@ -344,13 +344,13 @@
                     if ( PluginUtils.isMavenReport( mojo.getImplementation(), project ) )
                     {
                         sink.tableCell();
-                        iconValid( locale );
+                        sink.text( getBundle( locale ).getString( "report.plugin.isReport" ) );
                         sink.tableCell_();
                     }
                     else
                     {
                         sink.tableCell();
-                        iconError( locale );
+                        sink.text( getBundle( locale ).getString( "report.plugin.isNotReport" ) );
                         sink.tableCell_();
                     }
                 }
@@ -589,26 +589,6 @@
             }
 
             return jdk;
-        }
-
-        private void iconError( Locale locale )
-        {
-            sink.figure();
-            sink.figureCaption();
-            sink.text( getBundle( locale ).getString( "report.plugin.icon.error" ) );
-            sink.figureCaption_();
-            sink.figureGraphics( "images/icon_error_sml.gif" );
-            sink.figure_();
-        }
-
-        private void iconValid( Locale locale )
-        {
-            sink.figure();
-            sink.figureCaption();
-            sink.text( getBundle( locale ).getString( "report.plugin.icon.valid" ) );
-            sink.figureCaption_();
-            sink.figureGraphics( "images/icon_success_sml.gif" );
-            sink.figure_();
         }
     }
 }

Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report.properties
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report.properties?rev=634970&r1=634969&r2=634970&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report.properties (original)
+++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report.properties Sat Mar  8 06:09:17 2008
@@ -44,5 +44,5 @@
 report.plugin.usage.reporting=To use the report goals in your POM or parent POM
 report.plugin.configuration.end=For more information, see {"Guide to Configuring Plug-ins", http://maven.apache.org/guides/mini/guide-configuring-plugins.html}
 
-report.plugin.icon.valid=Yes
-report.plugin.icon.error=No
+report.plugin.isReport=Yes
+report.plugin.isNotReport=No

Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_de.properties
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_de.properties?rev=634970&r1=634969&r2=634970&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_de.properties (original)
+++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_de.properties Sat Mar  8 06:09:17 2008
@@ -21,8 +21,8 @@
 report.plugin.description=Dieser Bericht dokumentiert die Goals des Plugins und deren Parameter.
 report.plugin.title=Plugin Dokumentation
 
-report.plugin.goals.nogoal=Keine Goals verfügbar.
-report.plugin.goals.intro=Verfügbare Goals dieses Plugins:
+report.plugin.goals.nogoal=Keine Goals verf\u00fcgbar.
+report.plugin.goals.intro=Verf\u00fcgbare Goals dieses Plugins:
 report.plugin.goals.column.goal=Goal
 report.plugin.goals.column.isMavenReport=Bericht?
 report.plugin.goals.column.description=Beschreibung
@@ -30,7 +30,7 @@
 report.plugin.goal.deprecated=Missbilligt.
 
 report.plugin.systemrequirements=Systemvoraussetzungen
-report.plugin.systemrequirements.intro=Die folgende Tabelle listet die Mindestanforderungen zum Ausführen dieses Plugins auf:
+report.plugin.systemrequirements.intro=Die folgende Tabelle listet die Mindestanforderungen zum Ausf\u00fchren dieses Plugins auf:
 report.plugin.systemrequirements.nominimum=Keine Mindestanforderung.
 report.plugin.systemrequirements.maven=Maven
 report.plugin.systemrequirements.jdk=JDK
@@ -38,11 +38,11 @@
 report.plugin.systemrequirements.diskspace=Festplatte
 
 report.plugin.usage=Gebrauch
-report.plugin.usage.intro=Sie können "mvn -up" ausführen, um die aktuellste Version dieses Plugins herunterzuladen oder die gewünschte Version in der Plugin-Konfiguration Ihres Projekts angeben:
+report.plugin.usage.intro=Sie k\u00f6nnen "mvn -up" ausf\u00fchren, um die aktuellste Version dieses Plugins herunterzuladen oder die gew\u00fcnschte Version in der Plugin-Konfiguration Ihres Projekts angeben:
 report.plugin.usage.pluginManagement=Zum Definieren der Plugin-Version in der Eltern-POM
-report.plugin.usage.plugins=Zum Verwenden der Plugin-Goals während des Build-Vorgangs eines Projekts
-report.plugin.usage.reporting=Zum Erzeugen der Berichte für die Projektdokumentation
-report.plugin.configuration.end=Für weitergehende Informationen lesen Sie bitte den Artikel {"Guide to Configuring Plug-ins", http://maven.apache.org/guides/mini/guide-configuring-plugins.html}.
+report.plugin.usage.plugins=Zum Verwenden der Plugin-Goals w\u00e4hrend des Build-Vorgangs eines Projekts
+report.plugin.usage.reporting=Zum Erzeugen der Berichte f\u00fcr die Projektdokumentation
+report.plugin.configuration.end=F\u00fcr weitergehende Informationen lesen Sie bitte den Artikel {"Guide to Configuring Plug-ins", http://maven.apache.org/guides/mini/guide-configuring-plugins.html}.
 
-report.plugin.icon.valid=Ja
-report.plugin.icon.error=Nein
+report.plugin.isReport=Ja
+report.plugin.isNotReport=Nein

Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_fr.properties
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_fr.properties?rev=634970&r1=634969&r2=634970&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_fr.properties (original)
+++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/resources/plugin-report_fr.properties Sat Mar  8 06:09:17 2008
@@ -44,5 +44,5 @@
 report.plugin.usage.reporting=Pour utiliser les goals de rapports dans votre POM ou POM parent
 report.plugin.configuration.end=Pour plus d'informations, consultez {"Guide to Configuring Plug-ins", http://maven.apache.org/guides/mini/guide-configuring-plugins.html}
 
-report.plugin.icon.valid=Oui
-report.plugin.icon.error=Non
+report.plugin.isReport=Oui
+report.plugin.isNotReport=Non