You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/03/28 12:15:09 UTC
Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57993/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Bugs: AMBARI-20603
https://issues.apache.org/jira/browse/AMBARI-20603
Repository: ambari
Description
-------
* Avoid duplicate trunk compilation (caused by Hadoop-specific code)
* Move RAT check before javac warnings check
* Get rid of some Hadoop-specific code (not applicable to Ambari)
Diffs
-----
dev-support/test-patch.sh 222a79ab3d2582ef26cdadfd69133d3e099be16b
Diff: https://reviews.apache.org/r/57993/diff/1/
Testing
-------
Tested manually with 3 different "test" patches:
* one that builds fine without problems
* another which introduces checkstyle violation
* one that introduces RAT violation
Thanks,
Attila Doroszlai
Re: Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57993/#review170309
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On March 28, 2017, 2:15 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57993/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 2:15 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-20603
> https://issues.apache.org/jira/browse/AMBARI-20603
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Avoid duplicate trunk compilation (caused by Hadoop-specific code)
> * Move RAT check before javac warnings check
> * Get rid of some Hadoop-specific code (not applicable to Ambari)
>
>
> Diffs
> -----
>
> dev-support/test-patch.sh 222a79ab3d2582ef26cdadfd69133d3e099be16b
>
>
> Diff: https://reviews.apache.org/r/57993/diff/1/
>
>
> Testing
> -------
>
> Tested manually with 3 different "test" patches:
>
> * one that builds fine without problems
> * another which introduces checkstyle violation
> * one that introduces RAT violation
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57993/#review170307
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On March 28, 2017, 12:15 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57993/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 12:15 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-20603
> https://issues.apache.org/jira/browse/AMBARI-20603
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Avoid duplicate trunk compilation (caused by Hadoop-specific code)
> * Move RAT check before javac warnings check
> * Get rid of some Hadoop-specific code (not applicable to Ambari)
>
>
> Diffs
> -----
>
> dev-support/test-patch.sh 222a79ab3d2582ef26cdadfd69133d3e099be16b
>
>
> Diff: https://reviews.apache.org/r/57993/diff/1/
>
>
> Testing
> -------
>
> Tested manually with 3 different "test" patches:
>
> * one that builds fine without problems
> * another which introduces checkstyle violation
> * one that introduces RAT violation
>
>
> Thanks,
>
> Attila Doroszlai
>
>