You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2024/06/25 13:57:00 UTC
[jira] [Resolved] (YUNIKORN-2683) Unnecessary error is logged when resource usage is increased
[ https://issues.apache.org/jira/browse/YUNIKORN-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Bacsko resolved YUNIKORN-2683.
------------------------------------
Fix Version/s: 1.6.0
Resolution: Fixed
> Unnecessary error is logged when resource usage is increased
> ------------------------------------------------------------
>
> Key: YUNIKORN-2683
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2683
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The refactored code in YUNIKORN-2542 contains an unnecessary warning message:
> {noformat}
> appGroup := userTracker.getGroupForApp(applicationID)
> log.Log(log.SchedUGM).Debug("Increasing resource usage for user",
> zap.String("user", user.User),
> zap.String("queue path", queuePath),
> zap.String("application", applicationID),
> zap.String("group", appGroup),
> zap.Stringer("resource", usage))
> groupTracker := m.GetGroupTracker(appGroup)
> if groupTracker == nil {
> log.Log(log.SchedUGM).Error("group tracker should be available in groupTrackers map",
> zap.String("application", applicationID),
> zap.String("group", appGroup))
> return
> }
> ...
> {noformat}
> We don't always have a {{groupTracker}}. The previous code simply called {{increaseTrackedResource()}} on an empty tracker:
> {noformat}
> func (ut *UserTracker) increaseTrackedResource(queuePath string, applicationID string, usage *resources.Resource) {
> ut.Lock()
> defer ut.Unlock()
> ut.events.sendIncResourceUsageForUser(ut.userName, queuePath, usage)
> hierarchy := strings.Split(queuePath, configs.DOT)
> ut.queueTracker.increaseTrackedResource(hierarchy, applicationID, user, usage)
> gt := ut.appGroupTrackers[applicationID]
> log.Log(log.SchedUGM).Debug("Increasing resource usage for group",
> zap.String("group", gt.getName()),
> zap.Strings("queue path", hierarchy),
> zap.String("application", applicationID),
> zap.Stringer("resource", usage))
> gt.increaseTrackedResource(queuePath, applicationID, usage, ut.userName) <- can be null
> }
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org