You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/08/24 16:41:30 UTC
[GitHub] athanatos commented on a change in pull request #1624: ISSUE #1623: ReadOnlyLedgerHandle: don't schedule monitorPendingAddOp…
athanatos commented on a change in pull request #1624: ISSUE #1623: ReadOnlyLedgerHandle: don't schedule monitorPendingAddOp…
URL: https://github.com/apache/bookkeeper/pull/1624#discussion_r212686848
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -238,15 +238,27 @@ public Integer getSample() {
return pendingAddOps.size();
}
});
- initializeExplicitLacFlushPolicy();
+
+ initializeWriteHandleState();
+ }
+
+ protected void initializeWriteHandleState() {
+ if (!getLedgerMetadata().isClosed()
+ && !(this instanceof ReadOnlyLedgerHandle)
Review comment:
Sure, might as well clean it up now that it doesn't get called in the other path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services