You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/17 06:40:43 UTC

[kudu-CR] KUDU-678. Avoid orphaning empty REDO delta blocks

Hello Jean-Daniel Cryans, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3100

to review the following change.

Change subject: KUDU-678. Avoid orphaning empty REDO delta blocks
......................................................................

KUDU-678. Avoid orphaning empty REDO delta blocks

In the somewhat-common case that a DiskRowSet is written with no
REDOs, we would previously leak a very small delta block. This
addresses this long-standing TODO by aborting the block in the case
that nothing was written.

Change-Id: Ic8c2a084959cb6cffeafa8b0984fcac4ae12ae04
---
M src/kudu/cfile/cfile_writer.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tserver/tablet_server-test.cc
6 files changed, 40 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/3100/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8c2a084959cb6cffeafa8b0984fcac4ae12ae04
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans