You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2004/09/01 17:14:33 UTC

cvs commit: httpd-2.0/server util.c

trawick     2004/09/01 08:14:33

  Modified:    .        CHANGES
               server   util.c
  Log:
  Fix the handling of URIs containing %2F when AllowEncodedSlashes
  is enabled.  Previously, such urls would still be rejected with
  404.
  
  Revision  Changes    Path
  1.1579    +4 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.1578
  retrieving revision 1.1579
  diff -u -r1.1578 -r1.1579
  --- CHANGES	28 Aug 2004 16:08:21 -0000	1.1578
  +++ CHANGES	1 Sep 2004 15:14:32 -0000	1.1579
  @@ -2,6 +2,10 @@
   
     [Remove entries to the current 2.0 section below, when backported]
   
  +  *) Fix the handling of URIs containing %2F when AllowEncodedSlashes
  +     is enabled.  Previously, such urls would still be rejected with
  +     404.  [Jeff Trawick]
  +
     *) mod_rewrite: Fix query string handling for proxied URLs. PR 14518.
        [michael teitler <michael.teitler cetelem.fr>,
         Jan Kratochvil <rcpt-dev.AT.httpd.apache.org jankratochvil.net>]
  
  
  
  1.148     +1 -1      httpd-2.0/server/util.c
  
  Index: util.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/util.c,v
  retrieving revision 1.147
  retrieving revision 1.148
  diff -u -r1.147 -r1.148
  --- util.c	9 Feb 2004 20:40:49 -0000	1.147
  +++ util.c	1 Sep 2004 15:14:33 -0000	1.148
  @@ -1581,7 +1581,7 @@
               else {
                   char decoded;
                   decoded = x2c(y + 1);
  -                if (IS_SLASH(decoded)) {
  +                if (!IS_SLASH(decoded)) {
                       *x++ = *y++;
                       *x = *y;
                   }
  
  
  

Re: cvs commit: httpd-2.0/server util.c

Posted by Nick Kew <ni...@webthing.com>.
On Wed, 1 Sep 2004, Jeff Trawick wrote:

> On Wed, 1 Sep 2004 20:36:07 +0100 (BST), Nick Kew <ni...@webthing.com> wrote:
> >
> > FWIW, I fised that one in the proxy context about two months ago.
> > But I haven't looked at it in the general case.
>
> was that this change entry?
>
>   *) mod_proxy: multiple bugfixes, principally support cookies in
> 	ProxyPassReverse, and don't canonicalise URL passed to backend.
> 	Documentation correspondingly updated. [Nick Kew <nick webthing.com>]

Yes, that sounds right.  Though I think the CHANGES entry may have
lagged the actual update.  A quick look at CVS shows a datestamp of
Tue Jun 29 06:37:21 2004 UTC

-- 
Nick Kew

Re: cvs commit: httpd-2.0/server util.c

Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, 1 Sep 2004 20:36:07 +0100 (BST), Nick Kew <ni...@webthing.com> wrote:
> On Wed, 1 Sep 2004, Jeff Trawick wrote:
> 
> >
> > I can't see how this ever worked before :(  Any comments from the crowd?
> 
> FWIW, I fised that one in the proxy context about two months ago.
> But I haven't looked at it in the general case.

was that this change entry?

  *) mod_proxy: multiple bugfixes, principally support cookies in
	ProxyPassReverse, and don't canonicalise URL passed to backend.
	Documentation correspondingly updated. [Nick Kew <nick webthing.com>]

Re: cvs commit: httpd-2.0/server util.c

Posted by Nick Kew <ni...@webthing.com>.
On Wed, 1 Sep 2004, Jeff Trawick wrote:

>
> I can't see how this ever worked before :(  Any comments from the crowd?

FWIW, I fised that one in the proxy context about two months ago.
But I haven't looked at it in the general case.

-- 
Nick Kew

Re: cvs commit: httpd-2.0/server util.c

Posted by Jeff Trawick <tr...@gmail.com>.
On 1 Sep 2004 15:14:33 -0000, trawick@apache.org <tr...@apache.org> wrote:
> trawick     2004/09/01 08:14:33
> 
>   Modified:    .        CHANGES
>                server   util.c
>   Log:
>   Fix the handling of URIs containing %2F when AllowEncodedSlashes
>   is enabled.  Previously, such urls would still be rejected with
>   404.

I can't see how this ever worked before :(  Any comments from the crowd?