[jira] Commented: (OFBIZ-1237) Add the ability to copy ECA action result Map to the service result Map

["David E. Jones (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538397 ] 

David E. Jones commented on OFBIZ-1237:
---------------------------------------

I reviewed this patch and you comments, and I'm a little confused so here they are one at a time:

> To be more specific: If line 133 is executed, then things like line 177 and line 186 won't work - because the source and destination objects are identical.

Do you mean the condition currently on line 179? As I see it the worst case scenario there is that the error message list is copied again.

> I originally had it copy only on success because otherwise the results of lines 157 to 189 would be overwritten by the copy. 

By having it run before this other error handling that error handling code will copy over what happens before.

=============================

In general I guess the real question is: are you having any problems with this in the security or permission code you are working on? If so let me know and I'll look into it and see if a better way of coding this up can help.



> Add the ability to copy ECA action result Map to the service result Map
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1237
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1237
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ServiceEcaAction.patch, ServiceEcaAction.patch, ServiceEcaAction.patch, ServiceEcaAction.patch
>
>
> The service dispatcher uses the result Map from the initial service invoked and it ignores the result Map of any ECAs that are invoked. So, any values that an ECA service attempts to return are ignored.  It would be preferable to have an action attribute that permits copying the action's result Map to the service's result Map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.