You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/04 07:53:57 UTC
[GitHub] zeppelin pull request #1836: [ZEPPELIN-1887] fix: DON'T create new para when...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1836
[ZEPPELIN-1887] fix: DON'T create new para when run all paragraphs
### What is this PR for?
Clicking `Run all paragraphs` adds new paragraph. This is not the intended behavior.
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
[ZEPPELIN-1887](https://issues.apache.org/jira/browse/ZEPPELIN-1887)
### How should this be tested?
1. Click `Run all paragraph button` in a note
2. Check whether new paragraph is added or not.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1887/do-not-create-paragraph-when-run-all-parag
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1836
----
commit 333643280b6fa958c7f28570212efdee63566562
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-04T07:51:23Z
fix: DON'T create new para when run all paragraphs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1836: [ZEPPELIN-1887] fix: DON'T create new para when run al...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1836
Tested and it works very well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1836: [ZEPPELIN-1887] fix: DON'T create new para when run al...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1836
CI failure is irrelevant.
Test and LGTM.
While this provides fix for breaking feature, merging it as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1836: [ZEPPELIN-1887] fix: DON'T create new para when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1836
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1836: [ZEPPELIN-1887] fix: DON'T create new para when run al...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1836
Tested and works well as before \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---