You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/09/28 07:47:00 UTC

[jira] [Commented] (HDFS-16784) use write lock in #DatanodeAdminBackoffMonitor.scanDatanodeStorage

    [ https://issues.apache.org/jira/browse/HDFS-16784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610403#comment-17610403 ] 

ASF GitHub Bot commented on HDFS-16784:
---------------------------------------

liubingxing opened a new pull request, #4943:
URL: https://github.com/apache/hadoop/pull/4943

   In #DatanodeAdminBackoffMonitor.scanDatanodeStorage, it uses a read lock to protect the function #isBlockReplicatedOk.
   
   But we found that the function #isBlockReplicatedOk may update the #neededReconstruction under certain conditions.
   
   ![image](https://user-images.githubusercontent.com/2844826/192719789-b9e2a572-9607-4569-8ac3-dba7680e200b.png)
   
   
   Should we replace the read lock with write lock?




> use write lock in #DatanodeAdminBackoffMonitor.scanDatanodeStorage
> ------------------------------------------------------------------
>
>                 Key: HDFS-16784
>                 URL: https://issues.apache.org/jira/browse/HDFS-16784
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: qinyuren
>            Priority: Major
>         Attachments: image-2022-09-28-15-37-24-622.png
>
>
> In #DatanodeAdminBackoffMonitor.scanDatanodeStorage, it uses a read lock to protect the function #isBlockReplicatedOk.
> But we found that the function #isBlockReplicatedOk may update the #neededReconstruction under certain conditions.
> !image-2022-09-28-15-37-24-622.png!
> Should we replace the read lock with write lock?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org