[GitHub] [ozone] kerneltime commented on a diff in pull request #4443: HDDS-7098. Provide a way for admin to identify all unhealthy container replicas

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #4443:
URL: https://github.com/apache/ozone/pull/4443#discussion_r1175528420


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -405,6 +405,7 @@ message ContainerReplicaHistoryProto {
     required int64 firstSeenTime = 2;
     required int64 lastSeenTime = 3;
     required int64 bcsId = 4;
+    required string state = 5;

Review Comment:
   There needs to be a powerful reason for making the proto message `required`. I would change this to optional. If the code depends on it, it should handle it rather than having proto layer throw an exception on parsing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org