You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:59:43 UTC

[GitHub] [superset] zhaoyongjie commented on pull request #19483: fix: flaky test for charts changed on

zhaoyongjie commented on pull request #19483:
URL: https://github.com/apache/superset/pull/19483#issuecomment-1085556288


   > As it's really challenging to get these timedeltas aligned, I wonder if we should just do `assert data["result"][0]["changed_on_delta_humanized"] in ("now", "a second ago")`? Not elegant, I know, but should work with very high confidence..
   
   Unfortunately, `humanize.naturaltime` doesn't support minutes by **minimum unit**. I will change to now and 1 second ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org