[GitHub] [spark] zero323 commented on a change in pull request #34225: [SPARK-36885][PYTHON] Inline type hints for pyspark.sql.dataframe

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #34225:
URL: https://github.com/apache/spark/pull/34225#discussion_r725408880



##########
File path: python/pyspark/sql/__init__.pyi
##########
@@ -29,7 +29,7 @@ from pyspark.sql.dataframe import (  # noqa: F401
     DataFrameStatFunctions as DataFrameStatFunctions,
 )
 from pyspark.sql.group import GroupedData as GroupedData  # noqa: F401
-from pyspark.sql.observation import Observation  # noqa: F401
+from pyspark.sql.observation import Observation as Observation # noqa: F401

Review comment:
       If it is in `__all__` of `__init__.py` then it should be here, since we import directly from `pyspark.sql`:
   
   https://github.com/apache/spark/blob/07ecbc4049aa7f8daa11e6a924c37c1db2f53c73/python/pyspark/sql/dataframe.py#L1994
   
   But it won't be necessary once #34203 is merged.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org