You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Jesse Ciancetta <jc...@mitre.org> on 2011/08/03 21:43:41 UTC
Review Request: Please make the decrypt method in BlobCrypterSecurityToken
public so it can be used from external callers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Please make the decrypt method in BlobCrypterSecurityToken public so it can be used from external callers. For an example of where we're using this method externally please see:
http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/provider/opensocial/service/impl/EncryptedBlobSecurityTokenService.java
This addresses bugs RAVE-155 and SHINDIG-1560.
https://issues.apache.org/jira/browse/RAVE-155
https://issues.apache.org/jira/browse/SHINDIG-1560
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java 966481
Diff: https://reviews.apache.org/r/1278/diff
Testing
-------
Thanks,
Jesse
Re: Review Request: Please make the decrypt method in
BlobCrypterSecurityToken public so it can be used from external callers.
Posted by Jesse Ciancetta <jc...@mitre.org>.
> On 2011-08-04 01:03:39, Ryan Baxter wrote:
> > Is there a reason why you can't use BlobCrypterSecurityTokenCodec as the comment suggests?
I did look at using the BlobCrypterSecurityTokenCodec as the existing comment suggests, but the problem is that it's fairly Shindig specific and I'm using these classes from outside of Shindig (Apache Rave). For example -- the constructor of the BlobCrypterSecurityTokenCodec takes a ContainerConfig instance, which is something Rave knows nothing about. Of course I could create an instance of a ContainerConfig object just for this purpose and stuff the right values into it to make things work, but it seems like I shouldn't need to do that.
I think whoever made the decrypt method in the BlobCrypterSecurityToken package-private in the first place probably just hadn't considered use cases outside of Shindig.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/#review1281
-----------------------------------------------------------
On 2011-08-03 19:43:41, Jesse Ciancetta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1278/
> -----------------------------------------------------------
>
> (Updated 2011-08-03 19:43:41)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Please make the decrypt method in BlobCrypterSecurityToken public so it can be used from external callers. For an example of where we're using this method externally please see:
>
> http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/provider/opensocial/service/impl/EncryptedBlobSecurityTokenService.java
>
>
> This addresses bugs RAVE-155 and SHINDIG-1560.
> https://issues.apache.org/jira/browse/RAVE-155
> https://issues.apache.org/jira/browse/SHINDIG-1560
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java 966481
>
> Diff: https://reviews.apache.org/r/1278/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesse
>
>
Re: Review Request: Please make the decrypt method in
BlobCrypterSecurityToken public so it can be used from external callers.
Posted by Jesse Ciancetta <jc...@mitre.org>.
> On 2011-08-04 01:03:39, Ryan Baxter wrote:
> > Is there a reason why you can't use BlobCrypterSecurityTokenCodec as the comment suggests?
>
> Jesse Ciancetta wrote:
> I did look at using the BlobCrypterSecurityTokenCodec as the existing comment suggests, but the problem is that it's fairly Shindig specific and I'm using these classes from outside of Shindig (Apache Rave). For example -- the constructor of the BlobCrypterSecurityTokenCodec takes a ContainerConfig instance, which is something Rave knows nothing about. Of course I could create an instance of a ContainerConfig object just for this purpose and stuff the right values into it to make things work, but it seems like I shouldn't need to do that.
>
> I think whoever made the decrypt method in the BlobCrypterSecurityToken package-private in the first place probably just hadn't considered use cases outside of Shindig.
I just SVN up'd and it looks like Paul applied this patch last night -- so I'll go ahead and close out this review.
Thanks to Paul for applying, and thanks to Ryan for taking a look at it!
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/#review1281
-----------------------------------------------------------
On 2011-08-03 19:43:41, Jesse Ciancetta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1278/
> -----------------------------------------------------------
>
> (Updated 2011-08-03 19:43:41)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Please make the decrypt method in BlobCrypterSecurityToken public so it can be used from external callers. For an example of where we're using this method externally please see:
>
> http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/provider/opensocial/service/impl/EncryptedBlobSecurityTokenService.java
>
>
> This addresses bugs RAVE-155 and SHINDIG-1560.
> https://issues.apache.org/jira/browse/RAVE-155
> https://issues.apache.org/jira/browse/SHINDIG-1560
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java 966481
>
> Diff: https://reviews.apache.org/r/1278/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesse
>
>
Re: Review Request: Please make the decrypt method in
BlobCrypterSecurityToken public so it can be used from external callers.
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1278/#review1281
-----------------------------------------------------------
Is there a reason why you can't use BlobCrypterSecurityTokenCodec as the comment suggests?
- Ryan
On 2011-08-03 19:43:41, Jesse Ciancetta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1278/
> -----------------------------------------------------------
>
> (Updated 2011-08-03 19:43:41)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Please make the decrypt method in BlobCrypterSecurityToken public so it can be used from external callers. For an example of where we're using this method externally please see:
>
> http://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal/src/main/java/org/apache/rave/provider/opensocial/service/impl/EncryptedBlobSecurityTokenService.java
>
>
> This addresses bugs RAVE-155 and SHINDIG-1560.
> https://issues.apache.org/jira/browse/RAVE-155
> https://issues.apache.org/jira/browse/SHINDIG-1560
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java 966481
>
> Diff: https://reviews.apache.org/r/1278/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesse
>
>