You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Swapnil Bawaskar (JIRA)" <ji...@apache.org> on 2018/02/01 22:52:16 UTC

[jira] [Closed] (GEODE-3872) Consolidate GfshShellConnectionRule assertions

     [ https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Swapnil Bawaskar closed GEODE-3872.
-----------------------------------

> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>
>                 Key: GEODE-3872
>                 URL: https://issues.apache.org/jira/browse/GEODE-3872
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, tests
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>            Priority: Major
>             Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on GfshShellConnectionRule that implicitly make certain kinds of assertions.  (For example, assertions on the command result status or on the output text.)  It would make the code more maintainable to separate the various assertion methods into a separate class and to have a single executeCommand method.
> (See e.g. http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)