[GitHub] [cordova-electron] erisu commented on pull request #180: Fix Electron window is hidden in windows, stdio ignored

[GitBox <gi...@apache.org>]

erisu commented on pull request #180:
URL: https://github.com/apache/cordova-electron/pull/180#issuecomment-756621967


   Hey @zoltan-mihalyi,
   
   Thank you for the PR.
   
   I have configured my Windows environment and tested the before and after case to confirm the original issue and fix.
   
   I would like to actually split this PR into two PRs. I know this PR is small and only changes one line, but IMO this PR is doing two things, a fix and a feature.
   
   You can make the second PR based from the first. You or I can rebasae after we merge in the first fix PR.
   
   ### First PR (Fix)
   
   Lets convert this PR into a fix only PR. 
   
   * Change the PR title into something like this:
     > fix(windows): electron window not displaying
   * Update the description to only apply for this fix.
   * Update the code to only apply the fix.
   
   ### Second PR (Feature)
   
   IMO, adding the `stdio` flag is more of a feature request and not apart of the fix.
   
   Lets make a new PR for this feature request.
   
   * Create a PR title into something like this:
     > feat: display electron’s process stdio in terminal
   * Set the description explaining the new feature, etc.
   * Add new feature code.
   
   ### Overall
   
   The changes are good and works..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org